search

meza / minecraft-mod-manager

A CLI utility to Manage Minecraft Mods
https://discord.gg/dvg3tcQCPW
GNU General Public License v3.0
30 stars 3 forks source link

Ambiguous output from scan if jar file was renamed #282

Closed morgantic closed 3 months ago

morgantic commented 1 year ago

What happened?

After running scan, I got this output (truncated for better readability):

`Mezacraft S3 mmm test.minecraft> .\mmm.exe scan -p curseforge ✅Found unmanaged mod: Axolotl Bucket Fix ✅Found unmanaged mod: Amecs (Fabric) ✅Found unmanaged mod: Borderless Mining [...] ✅Found unmanaged mod: Simple Voice Chat ? Do you want to add these mods and/or make changes to your config? Yes

The following files cannot be matched to any mod on any of the platforms:

❌ Mezacraft S3 mmm test.minecraft\mods\Axolotl-Bucket-Fix-Mod-Fabric-1.19.2.jar ❌ Mezacraft S3 mmm test.minecraft\mods\BetterPvP_22.17.0_Fabric_1.19.1.jar`

The Bucket Fix is listed both as found and not matched - and it appears in the modlist.json as well as in the output of mmm list.

What did you expect to happen?

I expected a mod to be either found as unmanaged or listed as unmatched.

Which command did you run?

mmm.exe scan -p curseforge

Operating System

Windows

What version of MMM are you running?

error: unknown command 'version' (It's 1.2.1 though)

Contents of the modlist.json

{
  "loader": "fabric",
  "gameVersion": "1.19.2",
  "defaultAllowedReleaseTypes": [
    "beta",
    "release"
  ],
  "modsFolder": "./mods",
  "mods": [
    {
      "type": "curseforge",
      "id": "495453",
      "name": "Axolotl Bucket Fix"
    },
    {
      "type": "curseforge",
      "id": "324564",
      "name": "Amecs (Fabric)"
    },
    {
      "type": "curseforge",
      "id": "310205",
      "name": "Borderless Mining"
    },
    {
      "type": "curseforge",
      "id": "510234",
      "name": "Camera Utils"
    },
    {
      "type": "curseforge",
      "id": "667464",
      "name": "Better Statistics Screen (Fabric/Forge)"
    },
    {
      "type": "curseforge",
      "id": "349240",
      "name": "Carpet Extra"
    },
    {
      "type": "curseforge",
      "id": "459496",
      "name": "Indium"
    },
    {
      "type": "curseforge",
      "id": "325471",
      "name": "Inventory Sorting"
    },
    {
      "type": "curseforge",
      "id": "242064",
      "name": "Item Scroller"
    },
    {
      "type": "curseforge",
      "id": "428912",
      "name": "Krypton"
    },
    {
      "type": "curseforge",
      "id": "356461",
      "name": "Logical Zoom"
    },
    {
      "type": "curseforge",
      "id": "244260",
      "name": "MiniHUD"
    },
    {
      "type": "curseforge",
      "id": "256087",
      "name": "Notes"
    },
    {
      "type": "curseforge",
      "id": "303119",
      "name": "MaLiLib"
    },
    {
      "type": "curseforge",
      "id": "447673",
      "name": "Sodium Extra"
    },
    {
      "type": "curseforge",
      "id": "687609",
      "name": "Content Creator Server Status"
    },
    {
      "type": "curseforge",
      "id": "521783",
      "name": "Starlight (Fabric)"
    },
    {
      "type": "curseforge",
      "id": "297344",
      "name": "Tweakeroo"
    },
    {
      "type": "curseforge",
      "id": "419699",
      "name": "Architectury API (Fabric/Forge)"
    },
    {
      "type": "curseforge",
      "id": "403815",
      "name": "AdvancementInfo"
    },
    {
      "type": "curseforge",
      "id": "319473",
      "name": "Autofish"
    },
    {
      "type": "curseforge",
      "id": "248787",
      "name": "AppleSkin"
    },
    {
      "type": "curseforge",
      "id": "360438",
      "name": "Lithium (Fabric)"
    },
    {
      "type": "curseforge",
      "id": "308702",
      "name": "Mod Menu"
    },
    {
      "type": "curseforge",
      "id": "308892",
      "name": "Litematica"
    },
    {
      "type": "curseforge",
      "id": "317780",
      "name": "Xaero's World Map"
    },
    {
      "type": "curseforge",
      "id": "274816",
      "name": "NBT Tooltip"
    },
    {
      "type": "curseforge",
      "id": "401648",
      "name": "BetterF3"
    },
    {
      "type": "curseforge",
      "id": "531351",
      "name": "Continuity"
    },
    {
      "type": "curseforge",
      "id": "348521",
      "name": "Cloth Config API (Fabric/Forge)"
    },
    {
      "type": "curseforge",
      "id": "349239",
      "name": "Carpet"
    },
    {
      "type": "curseforge",
      "id": "394468",
      "name": "Sodium"
    },
    {
      "type": "curseforge",
      "id": "306612",
      "name": "Fabric API"
    },
    {
      "type": "curseforge",
      "id": "310111",
      "name": "Roughly Enough Items Fabric/Forge (REI)"
    },
    {
      "type": "curseforge",
      "id": "455508",
      "name": "Iris Shaders"
    },
    {
      "type": "curseforge",
      "id": "361579",
      "name": "spark"
    },
    {
      "type": "curseforge",
      "id": "225608",
      "name": "WorldEdit"
    },
    {
      "type": "curseforge",
      "id": "416089",
      "name": "Simple Voice Chat"
    }
  ]
}

Contents of the modlist-lock.json

[
  {
    "name": "Axolotl Bucket Fix",
    "type": "curseforge",
    "id": "495453",
    "fileName": "axolotl-item-fix-1.1.3.jar",
    "hash": "f60f9ea1e6afded2935ba5b1406aedcf429c20f8",
    "downloadUrl": "https://edge.forgecdn.net/files/3515/755/axolotl-item-fix-1.1.3.jar",
    "releasedOn": "2021-11-04T23:28:49.093Z"
  },
  {
    "name": "Amecs (Fabric)",
    "type": "curseforge",
    "id": "324564",
    "fileName": "amecs-1.3.8+mc.1.19-rc2.jar",
    "hash": "88c0fcf573a511760be66c562b14f9a3a056fee2",
    "downloadUrl": "https://edge.forgecdn.net/files/3819/822/amecs-1.3.8+mc.1.19-rc2.jar",
    "releasedOn": "2022-06-06T17:17:14.633Z"
  },
  {
    "name": "Borderless Mining",
    "type": "curseforge",
    "id": "310205",
    "fileName": "borderless-mining-1.1.5+1.19.jar",
    "hash": "08f98e28057a0fbdb288c947b7871def4b18b176",
    "downloadUrl": "https://edge.forgecdn.net/files/3865/813/borderless-mining-1.1.5+1.19.jar",
    "releasedOn": "2022-07-09T17:43:39.52Z"
  },
  {
    "name": "Camera Utils",
    "type": "curseforge",
    "id": "510234",
    "fileName": "camerautils-1.19.2-1.0.3.jar",
    "hash": "097e61337c34d23aa92a77fea5fc1796a9582fe0",
    "downloadUrl": "https://edge.forgecdn.net/files/4110/286/camerautils-1.19.2-1.0.3.jar",
    "releasedOn": "2022-11-24T17:06:21.463Z"
  },
  {
    "name": "Better Statistics Screen (Fabric/Forge)",
    "type": "curseforge",
    "id": "667464",
    "fileName": "betterstats-2.1.1+1.19.2.jar",
    "hash": "6d9bb9a086cc2035653dff77c312a330e3aecbe7",
    "downloadUrl": "https://edge.forgecdn.net/files/4264/229/betterstats-2.1.1+1.19.2.jar",
    "releasedOn": "2022-12-26T08:13:34.98Z"
  },
  {
    "name": "Carpet Extra",
    "type": "curseforge",
    "id": "349240",
    "fileName": "carpet-extra-1.19.2-1.4.84.jar",
    "hash": "cb1394e4dbc5c55f7c9eb6041188905ed72c7933",
    "downloadUrl": "https://edge.forgecdn.net/files/4066/596/carpet-extra-1.19.2-1.4.84.jar",
    "releasedOn": "2022-11-04T15:43:16.847Z"
  },
  {
    "name": "Indium",
    "type": "curseforge",
    "id": "459496",
    "fileName": "indium-1.0.9+mc1.19.2.jar",
    "hash": "a74ab16af990cf55dd1a3b5c76eadfc9ca25e25e",
    "downloadUrl": "https://edge.forgecdn.net/files/3957/480/indium-1.0.9+mc1.19.2.jar",
    "releasedOn": "2022-08-29T17:54:39.507Z"
  },
  {
    "name": "Inventory Sorting",
    "type": "curseforge",
    "id": "325471",
    "fileName": "InventorySorter-1.8.10-1.19.jar",
    "hash": "6ce11087da3555f0f48e18e067384abae3e5acc6",
    "downloadUrl": "https://edge.forgecdn.net/files/3885/990/InventorySorter-1.8.10-1.19.jar",
    "releasedOn": "2022-07-20T06:54:00.687Z"
  },
  {
    "name": "Item Scroller",
    "type": "curseforge",
    "id": "242064",
    "fileName": "itemscroller-fabric-1.19.2-0.17.1.jar",
    "hash": "dc49893a040804156c220219cd24befc46a1aac4",
    "downloadUrl": "https://edge.forgecdn.net/files/3923/56/itemscroller-fabric-1.19.2-0.17.1.jar",
    "releasedOn": "2022-08-07T13:53:46.873Z"
  },
  {
    "name": "Krypton",
    "type": "curseforge",
    "id": "428912",
    "fileName": "krypton-0.2.1.jar",
    "hash": "ebf02e469c028ea9e548401cacbb62e434874c08",
    "downloadUrl": "https://edge.forgecdn.net/files/3908/28/krypton-0.2.1.jar",
    "releasedOn": "2022-07-30T16:28:31.383Z"
  },
  {
    "name": "Logical Zoom",
    "type": "curseforge",
    "id": "356461",
    "fileName": "logical_zoom-0.0.17.jar",
    "hash": "1e7e2dbbedfa5fe7d47673026d40152882982357",
    "downloadUrl": "https://edge.forgecdn.net/files/3919/920/logical_zoom-0.0.17.jar",
    "releasedOn": "2022-08-05T18:37:04.493Z"
  },
  {
    "name": "MiniHUD",
    "type": "curseforge",
    "id": "244260",
    "fileName": "minihud-fabric-1.19.2-0.23.3.jar",
    "hash": "0f0e90fdd87301437c9cb7f383da8bac4c030928",
    "downloadUrl": "https://edge.forgecdn.net/files/3923/228/minihud-fabric-1.19.2-0.23.3.jar",
    "releasedOn": "2022-08-07T15:13:58.993Z"
  },
  {
    "name": "Notes",
    "type": "curseforge",
    "id": "256087",
    "fileName": "Notes-1.19.2-2.0.0-fabric.jar",
    "hash": "3c07d170c50b6aae656ce5d35fe3cb713bf2fefc",
    "downloadUrl": "https://edge.forgecdn.net/files/3937/913/Notes-1.19.2-2.0.0-fabric.jar",
    "releasedOn": "2022-08-16T23:11:03.21Z"
  },
  {
    "name": "MaLiLib",
    "type": "curseforge",
    "id": "303119",
    "fileName": "malilib-fabric-1.19.2-0.13.0.jar",
    "hash": "adc66c8c481293d6fe316da539eb5b8e46e8ac76",
    "downloadUrl": "https://edge.forgecdn.net/files/3923/52/malilib-fabric-1.19.2-0.13.0.jar",
    "releasedOn": "2022-08-07T13:52:33.83Z"
  },
  {
    "name": "Sodium Extra",
    "type": "curseforge",
    "id": "447673",
    "fileName": "sodium-extra-0.4.15+mc1.19.2-build.85.jar",
    "hash": "3fe4e5fde5deb39d4a5531ace18fa2ccc7d93fdb",
    "downloadUrl": "https://edge.forgecdn.net/files/4216/298/sodium-extra-0.4.15+mc1.19.2-build.85.jar",
    "releasedOn": "2022-12-20T14:09:59.947Z"
  },
  {
    "name": "Content Creator Server Status",
    "type": "curseforge",
    "id": "687609",
    "fileName": "status-1.19.2-1.0.0.jar",
    "hash": "8824d47f1a58fc00e3d8495747ed5b9b45a4f665",
    "downloadUrl": "https://edge.forgecdn.net/files/4024/702/status-1.19.2-1.0.0.jar",
    "releasedOn": "2022-10-10T17:26:02.82Z"
  },
  {
    "name": "Starlight (Fabric)",
    "type": "curseforge",
    "id": "521783",
    "fileName": "starlight-1.1.1+fabric.ae22326.jar",
    "hash": "de6fe932555604345477db89b59d59249909c640",
    "downloadUrl": "https://edge.forgecdn.net/files/3835/973/starlight-1.1.1+fabric.ae22326.jar",
    "releasedOn": "2022-06-17T13:04:25.707Z"
  },
  {
    "name": "Tweakeroo",
    "type": "curseforge",
    "id": "297344",
    "fileName": "tweakeroo-fabric-1.19.2-0.14.3.jar",
    "hash": "26f27bfe870778a8986aea9fb403aa812b5f2d83",
    "downloadUrl": "https://edge.forgecdn.net/files/3923/75/tweakeroo-fabric-1.19.2-0.14.3.jar",
    "releasedOn": "2022-08-07T14:03:54.723Z"
  },
  {
    "name": "Architectury API (Fabric/Forge)",
    "type": "curseforge",
    "id": "419699",
    "fileName": "architectury-6.2.46-fabric.jar",
    "hash": "210c1f482c84598e907713f073c8b712df850efa",
    "downloadUrl": "https://edge.forgecdn.net/files/3984/16/architectury-6.2.46-fabric.jar",
    "releasedOn": "2022-09-11T17:40:47.59Z"
  },
  {
    "name": "AdvancementInfo",
    "type": "curseforge",
    "id": "403815",
    "fileName": "advancementinfo-1.19.1-fabric0.58.5-1.3.1.jar",
    "hash": "9ba152030c480c329653f3ae654b3fca5421c23a",
    "downloadUrl": "https://edge.forgecdn.net/files/3907/238/advancementinfo-1.19.1-fabric0.58.5-1.3.1.jar",
    "releasedOn": "2022-07-30T09:05:45.313Z"
  },
  {
    "name": "Autofish",
    "type": "curseforge",
    "id": "319473",
    "fileName": "Autofish-0.9.5-fabric-mc1.19.jar",
    "hash": "223f5c25c2f2984f4d9c94129917a8a3622b1f19",
    "downloadUrl": "https://edge.forgecdn.net/files/3843/312/Autofish-0.9.5-fabric-mc1.19.jar",
    "releasedOn": "2022-06-22T01:17:19.687Z"
  },
  {
    "name": "AppleSkin",
    "type": "curseforge",
    "id": "248787",
    "fileName": "appleskin-fabric-mc1.19-2.4.1.jar",
    "hash": "7bd52695e82b1ddd1fdb3320154b68bf48dfff37",
    "downloadUrl": "https://edge.forgecdn.net/files/3927/567/appleskin-fabric-mc1.19-2.4.1.jar",
    "releasedOn": "2022-08-10T07:33:50.23Z"
  },
  {
    "name": "Lithium (Fabric)",
    "type": "curseforge",
    "id": "360438",
    "fileName": "lithium-fabric-mc1.19.2-0.10.4.jar",
    "hash": "8ff81f60681521e96b403fc3dd095f5c64b15745",
    "downloadUrl": "https://edge.forgecdn.net/files/4151/762/lithium-fabric-mc1.19.2-0.10.4.jar",
    "releasedOn": "2022-12-08T21:54:53.15Z"
  },
  {
    "name": "Mod Menu",
    "type": "curseforge",
    "id": "308702",
    "fileName": "modmenu-4.1.2.jar",
    "hash": "495674289dcba88b6df3d86b7590c7b192b993fe",
    "downloadUrl": "https://edge.forgecdn.net/files/4145/207/modmenu-4.1.2.jar",
    "releasedOn": "2022-12-08T03:36:06.797Z"
  },
  {
    "name": "Litematica",
    "type": "curseforge",
    "id": "308892",
    "fileName": "litematica-fabric-1.19.2-0.12.6.jar",
    "hash": "8caa74c61d30fa6ee20bd4390844c3d3854d9001",
    "downloadUrl": "https://edge.forgecdn.net/files/4259/743/litematica-fabric-1.19.2-0.12.6.jar",
    "releasedOn": "2022-12-24T22:19:10.91Z"
  },
  {
    "name": "Xaero's World Map",
    "type": "curseforge",
    "id": "317780",
    "fileName": "XaerosWorldMap_1.28.7_Fabric_1.19.1.jar",
    "hash": "efde86a2093103f150d317c5861720734cc56a7d",
    "downloadUrl": "https://edge.forgecdn.net/files/4193/8/XaerosWorldMap_1.28.7_Fabric_1.19.1.jar",
    "releasedOn": "2022-12-18T09:30:59.383Z"
  },
  {
    "name": "NBT Tooltip",
    "type": "curseforge",
    "id": "274816",
    "fileName": "nbttooltip-1.7.0.jar",
    "hash": "933cf7c726c68841c62d07feb42754e73a46a785",
    "downloadUrl": "https://edge.forgecdn.net/files/3841/393/nbttooltip-1.7.0.jar",
    "releasedOn": "2022-06-20T17:43:32.473Z"
  },
  {
    "name": "BetterF3",
    "type": "curseforge",
    "id": "401648",
    "fileName": "BetterF3-1.3.2-Fabric-1.19.jar",
    "hash": "c65443f1ac63aa7e5c16e379557641b76827cf9b",
    "downloadUrl": "https://edge.forgecdn.net/files/3884/453/BetterF3-1.3.2-Fabric-1.19.jar",
    "releasedOn": "2022-07-19T08:08:31.32Z"
  },
  {
    "name": "Continuity",
    "type": "curseforge",
    "id": "531351",
    "fileName": "continuity-2.0.1+1.19.jar",
    "hash": "d82700772659f65560202f1cbd0e744007b21a75",
    "downloadUrl": "https://edge.forgecdn.net/files/3927/270/continuity-2.0.1+1.19.jar",
    "releasedOn": "2022-08-10T01:00:37.29Z"
  },
  {
    "name": "Cloth Config API (Fabric/Forge)",
    "type": "curseforge",
    "id": "348521",
    "fileName": "cloth-config-9.0.94-fabric.jar",
    "hash": "9b218b97186b75e5701b343dddfea1081d8ba48d",
    "downloadUrl": "https://edge.forgecdn.net/files/4147/98/cloth-config-9.0.94-fabric.jar",
    "releasedOn": "2022-12-08T15:26:46.833Z"
  },
  {
    "name": "Carpet",
    "type": "curseforge",
    "id": "349239",
    "fileName": "fabric-carpet-1.19.2-1.4.84+v221018.jar",
    "hash": "9a88c3a004b15b1f776c988d8eae1cc191b4fbee",
    "downloadUrl": "https://edge.forgecdn.net/files/4033/215/fabric-carpet-1.19.2-1.4.84+v221018.jar",
    "releasedOn": "2022-10-18T14:05:51.49Z"
  },
  {
    "name": "Sodium",
    "type": "curseforge",
    "id": "394468",
    "fileName": "sodium-fabric-mc1.19.2-0.4.4+build.18.jar",
    "hash": "227648dc4f6a8604bafc282612a6de47eff70cd8",
    "downloadUrl": "https://edge.forgecdn.net/files/3957/319/sodium-fabric-mc1.19.2-0.4.4+build.18.jar",
    "releasedOn": "2022-08-29T16:03:40.65Z"
  },
  {
    "name": "Fabric API",
    "type": "curseforge",
    "id": "306612",
    "fileName": "fabric-api-0.71.0+1.19.2.jar",
    "hash": "3f2a4b23c5ee54e632c03c2af9b4817b7ca2dd3c",
    "downloadUrl": "https://edge.forgecdn.net/files/4287/704/fabric-api-0.71.0+1.19.2.jar",
    "releasedOn": "2023-01-02T14:45:19.007Z"
  },
  {
    "name": "Roughly Enough Items Fabric/Forge (REI)",
    "type": "curseforge",
    "id": "310111",
    "fileName": "RoughlyEnoughItems-9.1.550.jar",
    "hash": "5b81d7ce6f52fb0cd1fa467ef688a2d2e0eeeab8",
    "downloadUrl": "https://edge.forgecdn.net/files/4010/364/RoughlyEnoughItems-9.1.550.jar",
    "releasedOn": "2022-09-28T10:28:29.09Z"
  },
  {
    "name": "Iris Shaders",
    "type": "curseforge",
    "id": "455508",
    "fileName": "iris-mc1.19.2-1.5.0.jar",
    "hash": "0fab5a9ac4bc30794e12b7478fcb2e7036f02b33",
    "downloadUrl": "https://edge.forgecdn.net/files/4284/512/iris-mc1.19.2-1.5.0.jar",
    "releasedOn": "2023-01-01T03:36:36.563Z"
  },
  {
    "name": "spark",
    "type": "curseforge",
    "id": "361579",
    "fileName": "spark-1.9.26-fabric.jar",
    "hash": "3e12135a144f4165b4024f7d99c32c72a26bfacb",
    "downloadUrl": "https://edge.forgecdn.net/files/3879/542/spark-1.9.26-fabric.jar",
    "releasedOn": "2022-07-17T11:32:34.773Z"
  },
  {
    "name": "WorldEdit",
    "type": "curseforge",
    "id": "225608",
    "fileName": "worldedit-mod-7.2.12.jar",
    "hash": "3583d0182a2a5c96d13434ed48ebb29742228174",
    "downloadUrl": "https://edge.forgecdn.net/files/3922/622/worldedit-mod-7.2.12.jar",
    "releasedOn": "2022-08-07T07:21:31.07Z"
  },
  {
    "name": "Simple Voice Chat",
    "type": "curseforge",
    "id": "416089",
    "fileName": "voicechat-fabric-1.19.2-2.3.26.jar",
    "hash": "263fc89fb96a689a05682658bd26d533dbedadfd",
    "downloadUrl": "https://edge.forgecdn.net/files/4271/665/voicechat-fabric-1.19.2-2.3.26.jar",
    "releasedOn": "2022-12-27T09:11:50.673Z"
  }
]

I have updated

morgantic commented 1 year ago

Trying to mmm.exe u afterwards yields to the following output (not truncated, that's all there is):

`Mezacraft S3 mmm test.minecraft> .\mmm.exe u

Please fix the unresolved issues above manually or by running mmm scan, then try again.`

morgantic commented 1 year ago

Suspicion: For some reason I can't fully comprehend the .jar file name of the bucket fix mod in my .mods folder differs from the file name on curseforge. I do not know whether that's the reason for this behavior, but it seems like it could be?

morgantic commented 1 year ago

Suspicion confirmed. Re-downloading the mod with the right name resolved the ambiguity.

morgantic commented 1 year ago

Bug(?) is reproduceable:

`rename test> .\mmm.exe scan ✅Found unmanaged mod: Amecs ✅Found unmanaged mod: Axolotl Bucket Fix ✅Found unmanaged mod: Architectury API ✅Found unmanaged mod: AdvancementInfo ✅Found unmanaged mod: AppleSkin ✅Found unmanaged mod: Autofish ✅Found unmanaged mod: BetterF3 ? Do you want to add these mods and/or make changes to your config? Yes

The following files cannot be matched to any mod on any of the platforms:

❌ rename test\mods\BetterF3-renamed.jar ❌ rename test\mods\BetterPvP_22.17.0_Fabric_1.19.1.jar

rename test> .\mmm.exe u

Please fix the unresolved issues above manually or by running mmm scan, then try again.`

stale[bot] commented 1 year ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

github-actions[bot] commented 3 months ago

:tada: This issue has been resolved in version 2.0.0-next.13 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket:

github-actions[bot] commented 3 months ago

:tada: This issue has been resolved in version 2.0.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: