search

mezerotm / cmv

CMV is a citySDK based map visualizatoin tool
5 stars 5 forks source link

Fix color range #47

Closed NJTuley closed 7 years ago

NJTuley commented 7 years ago

The minimum value in our color ranges is almost transparent. We need to change it to where the minimum value, although lighter than the other values (definitely the lightest), it should still be plainly visible. Whether this is done by putting a thin border around all polygons, or just making the minimum color value a bit darker and easier to see

hardnett commented 7 years ago

I think this is essentially just choosing a new color palette for the shades. This is the current code:

cmv.js

// Step 1: Determines the array of colors
        // todo: find a way to pragmatically change the tint/shade
        let colors = ['#FEEDDE', '#FDBE85', '#FD8D3C', '#E6550D', '#A63603'];

Do we need more colors?

NJTuley commented 7 years ago

One consideration to keep in mind is to be sure that the minimum for the new range is clearly visible (not necessarily dark, just visible)

NJTuley commented 7 years ago

Also, do we want to have multiple color palettes for the different maps? Just so that all of the maps do not have their data drawn with the same palette?

hardnett commented 7 years ago

Having it visible is still primary.

Having different palettes for different maps is a good idea. That can be dealt with in the beta release as separate issue.

NJTuley commented 7 years ago

Fixed the color range and added a few other colors in for variation's sake (so all of the maps are not all one color range) colors