search

mezerotm / cmv

CMV is a citySDK based map visualizatoin tool
5 stars 5 forks source link

Error Handling and Display #62

Open NJTuley opened 7 years ago

NJTuley commented 7 years ago

I noticed that when the page runs into an error (i.e. invalid input given, or if citysdk does not have data for the given location+variable combination), there is no way for the user to be notified of this error. I think that we need to include some way, other than console.log, for the user to be notified of an error or invalid input, or etc. I am noticing that this will be needed at least for when the user inputs a place that does not have a valid place+time+variable data value in the census data api (I am noticing that we are not getting responses when we do certain place+variable combinations, like zip code 30022 and Income Per Capita often gets an empty response, and things like this). We need to be able to tell the user when this occurs (maybe after 10 null responses from the server say that there was no data for that place+variable combination?, we would need a way of differentiating between citysdk not having data for a place+variable combination and the ERROR HELLO we are currently dealing with, as both return a null response.features.

NJTuley commented 7 years ago

Also I assigned everyone to this just so we all see it, we can decide who actually wants to work on and change that, I just wanted everyone to see it first.

mezerotm commented 7 years ago

Maybe we should hold off on this until we fix ERROR HELLO, This seems like a fairly easy thing to implement, but if we write code to work around an issue we plan on fixing in the future then that code becomes obsolete, and we may forget to remove it.