search

mezg0 / vue-ui

https://ui.mezg0.com
MIT License
69 stars 1 forks source link

Disable scroll when Dialog, Sheet, etc is open. #2

Closed Blinks44 closed 11 months ago

Blinks44 commented 11 months ago

First of all, i appreciate your work man, keep going, vue world deserve frontend libraries like shadcnui!

I noticed one problem with all dialogs that has overlay, all of them should disable scroll behavior when opened. Originaly ark-ui adds classes to html and body tags to prevent this, but not in your library. I tried to understand why, but with no luck...

2023-07-10_11-45-54

mezg0 commented 11 months ago

Looks like ark has the functionality behind a prop.

I've updated the component -> https://ui.mezg0.com/component/alert-dialog

Blinks44 commented 11 months ago

Ahh, their docs lying that prevent scroll is the default behaviour… I think Sheet component should have preventscroll prop too?