search

mezis / blurrily

Millisecond fuzzy string matching for Ruby
MIT License
90 stars 14 forks source link

Moved to UUID references. #45

Closed rwasher closed 9 years ago

rwasher commented 9 years ago

Hey @mezis! We moved to UUIDs on our platform and as we rely pretty heavily on blurrily for our user inputs we extended it. I figure this is the easiest way for others to find this fork if they need it but I don't anticipate it actually being merged. Alternatively, do you know a nice way it could be made configurable?

Note that UUIDs must be v4 and start with a non-zero in this implementation. I think the issue is to do with the strtoul in http://fossies.org/dox/e2fsprogs-1.42.13/uuid_2parse_8c_source.html at line 66.

PS blurrily is awesome.

mezis commented 9 years ago

PS blurrily is awesome

Thanks @rwasher :)

Regarding making the reference type configurable, I'll try to think of a way but it may prove challenging. I don't think it's reasonable to just switch the implementation to UUIDs instead of 32-bit ints, as that'd make storage 4x larger for all users...

rwasher commented 9 years ago

Makes sense! I have closed the PR for now. The UUID version is available/supported at StitchedCode/blurrily (and a docker at mrmattwright/docker-blurrily-uuid) for if anyone finds this :).