Add Ruby 2.4 support - Githubissues

mezis / blurrily

Millisecond fuzzy string matching for Ruby

MIT License

90 stars 14 forks source link

Add Ruby 2.4 support #47

Closed tomasv closed 7 years ago

tomasv commented 7 years ago

https://github.com/mezis/blurrily/issues/46

I dug around and think found the issue.

-Werror makes all warning fatal during compilation, and for some reason unused argument warnings started appearing with Ruby 2.4.

The tests pass on my machine.

coveralls commented 7 years ago

Coverage decreased (-0.2%) to 94.595% when pulling 7ee16e2b7293a499b6c845d5f0a8703cad9790f4 on tomasv:feature/ruby24_compat into 496deee64a7e1c04b1241968dab46250e7b36569 on mezis:master.

tomasv commented 7 years ago

Seems the Travis build failed only on 1.9.3, is that an issue?

NoMethodError: undefined method `spec' for nil:NilClass

during bundle install

tomasv commented 7 years ago

Fixed the failing build on 1.9.3 as well, the cause was an out of date bundler.

coveralls commented 7 years ago

Coverage decreased (-0.2%) to 94.595% when pulling b0f0c829c96bc466d3fe6a66c323dd33acb566d8 on tomasv:feature/ruby24_compat into 496deee64a7e1c04b1241968dab46250e7b36569 on mezis:master.

tomasv commented 7 years ago

I worked around this by using my own fork. @mezis feel free to reopen. :)