search

mezis / git-whistles

A set of bells and whistles for your Git.
Other
64 stars 15 forks source link

cleanup travis.yml after using ht travis-start #32

Closed marcusleemitchell closed 10 years ago

marcusleemitchell commented 10 years ago

Used in conjustion with https://github.com/HouseTrip/ht/pull/23, this addition will clean up the added branch name used to kick of a travis build

mezis commented 10 years ago

Looks good to me. I'm midly uncomfortable as it's a bit HT-specific. @pedrocunha an opinion?

marcusleemitchell commented 10 years ago

I understand completely and to be honest this was the first stab at working the clean up into our workflow. In order to make it a unobtrusive as possible I was hoping to find an existing point in the process to hook into rather than create another command solely to clean up the small addition to the Travis config file.

Suggestions very welcome of course.

marcusleemitchell commented 10 years ago

I might have to make the operation conditional based on the existence of the config file. Remove anything HT specific.

pedrocunha commented 10 years ago

Hello @marcusleemitchell, thanks for your contribution. IMHO I don't think this should be part of git-whistles since this gem should be very abstract besides the integration with pivotal tracker and no ht-specifics (notice the commit message header). I would like to suggest that the ht internal gem we have has a command that wraps arounds git pull-request and does what you are expecting. i.e. ht pull-request. What do you think ?

marcusleemitchell commented 10 years ago

Hey Pedro.

Yep, that makes perfect sense. I'm going to be working on it his next week with an aim to presenting on Friday and having it be used soon after.

On Thu, Jul 31, 2014 at 7:29 PM, Pedro Cunha notifications@github.com wrote:

Hello @marcusleemitchell https://github.com/marcusleemitchell, thanks for your contribution. IMHO I don't think this should be part of git-whistles since this gem should be very abstract besides the integration with pivotal tracker and no ht-specifics (notice the commit message header). I would like to suggest that the ht internal gem we have has a command that wraps arounds git pull-request and does what you are expecting. i.e. ht pull-request. What do you think ?

— Reply to this email directly or view it on GitHub https://github.com/mezis/git-whistles/pull/32#issuecomment-50799239.

Marcus Mitchell -:- web developer and photographer marcusleemitchell.co.uk :: flickr.com/photos/marcusleemitchell :: twitter.com/marcusmitchell