search

mezis / git-whistles

A set of bells and whistles for your Git.
Other
64 stars 15 forks source link

Added git-jira-branch. #47

Closed martyphee closed 8 years ago

martyphee commented 8 years ago

This adds a JIRA integration. Only jira branch is in this PR.

pedrocunha commented 8 years ago

Thanks for your contribution @martyphee looks good, I left a few questions :)

pedrocunha commented 8 years ago

After you last commit did you have a go locally to see if everything is still working as expected? Sorry to ask you this, but I'm not really a JIRA user. The changes look good!

martyphee commented 8 years ago

It looks good.

image

pedrocunha commented 8 years ago

Perfect :+1:

martyphee commented 8 years ago

I just renamed the file to drop the .rb

pedrocunha commented 8 years ago

I'll try to issue a release tomorrow morning, as there are a few things to be released if that's ok. I'll ping you here

martyphee commented 8 years ago

That's good. If I get some time tonight I'm going to work on the create PR version.

On Wed, Jan 20, 2016 at 4:13 PM, Pedro Cunha notifications@github.com wrote:

I'll try to issue a release tomorrow morning, as there are a few things to be released if that's ok. I'll ping you here

— Reply to this email directly or view it on GitHub https://github.com/mezis/git-whistles/pull/47#issuecomment-173378859.

mezis commented 8 years ago

neato. thanks guys!

mezis commented 8 years ago

@pedrocunha I think you're gem owner already, so probably don't need me?

pedrocunha commented 8 years ago

Hey @martyphee do you mind trying out the new released version 1.0.1 to see if everything works for you? I did a bit of tidy up on your script (i missed some duplication on the code review). Thanks.

martyphee commented 8 years ago

I'll take a look.

On Fri, Jan 22, 2016 at 10:24 AM, Pedro Cunha notifications@github.com wrote:

Hey @martyphee https://github.com/martyphee do you mind trying out the new released version 1.0.1 to see if everything works for you? I did a bit of tidy up on your script (i missed some duplication on the code review). Thanks.

— Reply to this email directly or view it on GitHub https://github.com/mezis/git-whistles/pull/47#issuecomment-173967589.

martyphee commented 8 years ago

Can't seem to get it installed.

BR ICE-85-add-locale-based-routing ... | orderweb gem install git-whistles ERROR: While executing gem ... (Gem::Package::PathError) installing into parent path /Users/martinphee/.rbenv/versions/2.2.3/lib/ruby/gems/2.2.0/gems/libexec/runner.rb of /Users/martinphee/.rbenv/versions/2.2.3/lib/ruby/gems/2.2.0/gems/git-whistles-1.0.1 is not allowed

On Fri, Jan 22, 2016 at 10:24 AM, Pedro Cunha notifications@github.com wrote:

Hey @martyphee https://github.com/martyphee do you mind trying out the new released version 1.0.1 to see if everything works for you? I did a bit of tidy up on your script (i missed some duplication on the code review). Thanks.

— Reply to this email directly or view it on GitHub https://github.com/mezis/git-whistles/pull/47#issuecomment-173967589.

pedrocunha commented 8 years ago

Hi @martyphee i can replicate your issue if i try to install the gem under 2.3. in 2.2 seems to work fine for me. This is leaving me a bit puzzled. Will try to investigate this further.

pedrocunha commented 8 years ago

Hi @martyphee please give it a try again with version 1.0.2. Seems the problem was related to the gem being compiled with ruby 2.3.