mezis / git-whistles

A set of bells and whistles for your Git.
Other
64 stars 15 forks source link

Gem does not build on Rubygems 2.5.X with certain versions of Ruby #48

Closed pedrocunha closed 8 years ago

pedrocunha commented 8 years ago

If I try to install git-whistles under ruby 2.3.0 (pristine machine) I get the following error:

ERROR:  While executing gem ... (Gem::Package::PathError)`

@martyphee does also get the same problem when installing the gem under 2.2.3. I can't replicate that.

After some investigation looks like the culprit is the latest RubyGems version 2.5. This is the offending PR: https://github.com/rubygems/rubygems/pull/1209 which broke the support of symlinks in the gem files.

For now it doesn't seem a problem that be solved in git-whistles and the solution is to downgrade ruby gems. I've tried with 2.4.8 and works fine.

pedrocunha commented 8 years ago

\cc @martyphee

pedrocunha commented 8 years ago

Issue on rubygems: https://github.com/rubygems/rubygems/issues/1448

pedrocunha commented 8 years ago

Managed to fix the problem by compiling the gem under ruby 2.2.4. I've pushed to rubygems git-whistles 1.0.2 which I've confirmed locally that does install correctly on ruby 2.3.

martyphee commented 8 years ago

Looks go to me! I'll try to get the PR creator this week.

On Sat, Jan 23, 2016 at 11:48 AM, Pedro Cunha notifications@github.com wrote:

Managed to fix the problem by compiling the gem under ruby 2.2.4. I've pushed to rubygems git-whistles 1.0.2 which I've confirmed locally that does install correctly on ruby 2.3.

— Reply to this email directly or view it on GitHub https://github.com/mezis/git-whistles/issues/48#issuecomment-174207099.