Acceptance tests fixes/improvements

mezuro / kalibro_processor

Reimplementation of Kalibro processing

GNU Affero General Public License v3.0

2 stars 10 forks source link

Closed danielkza closed 8 years ago

danielkza commented 8 years ago

Some small fixes/improvements for issues/needs I ran into recently.

Print processing times after processing steps so we don't lose sight of performance in the future
Remove duplicate require of hooks.rb (it is already required automatically)
Change the MetricResult ID test to not rely on the existence of a hotspot result on the root - we can only be sure that will happen for tree metrics after aggregation.

rafamanzo commented 8 years ago

Do you think it is worth an CHANGELOG entry? As it is now clearly a bugfix I'd say yes. But if you disagree I can accept.

danielkza commented 8 years ago

It doesn't hurt to add an entry :smile:

rafamanzo commented 8 years ago

Looks like the seed 541produced unit test errors.

danielkza commented 8 years ago

@rafamanzo Should be fixed now.

rafamanzo commented 8 years ago

Well done. I've tested locally with the fault seed and everything pass.