search

mezuro / kalibro_processor

Reimplementation of Kalibro processing
GNU Affero General Public License v3.0
2 stars 10 forks source link

Remove unnecessary timestamp columns from models #219

Open danielkza opened 8 years ago

danielkza commented 8 years ago

Remove the timestamp columns from the KalibroModule, ModuleResult, MetricResult and ProcessingTime models. They were not used by anything, but needed to be populated and inserted in millions of records.

This will require a KalibroClient change in the future.

rafamanzo commented 8 years ago

Have you tested how does this affect kalibro_client?

danielkza commented 8 years ago

It will be necessary to change the processor entities to not expect those columns. We just need to make sure we release a new kalibro_client stable version together with the next stable processor version.

danielkza commented 8 years ago

Rebased to master. Ping @mezuro/core.

rafamanzo commented 8 years ago

I'm waiting for https://github.com/mezuro/kalibro_processor/pull/225 to get merged before this, so the release of 1.3.3 is easier.

diegoamc commented 8 years ago

Ok for me :+1:

danielkza commented 8 years ago

This probably should go into a new major version.

rafamanzo commented 8 years ago

A question came to me right now: do we have any reference if this has any impact on insertion time? Or select times? Or DB size in disk?