search

mezuro / kalibro_processor

Reimplementation of Kalibro processing
GNU Affero General Public License v3.0
2 stars 10 forks source link

Add metric extraction utility methods to Context #227

Open danielkza opened 8 years ago

danielkza commented 8 years ago

Code for selecting some metrics among those stored in a context was repeated in multiple places. Extract it to methods in preparation for the interpreting processing step rewrite (can also be incorporated to the aggregation rewrite in #225).

diegoamc commented 8 years ago

Good refactoring! Congratulations! Apart from my only comment everything looks fine.

danielkza commented 8 years ago

Any other comments? When this is merge I can make the interpreting optimization PR.

diegoamc commented 8 years ago

For me it's good to go. @mezuro/core ?

rafamanzo commented 8 years ago

Would you mind if I split this commit into smaller ones by Friday?

danielkza commented 8 years ago

Not at all. I can do it today if you tell me what you think should be split.

rafamanzo commented 8 years ago

I was thinking about:

What do you think?