mezuro / prezento

Prezento is the web interface for Mezuro.
http://mezuro.github.io/
GNU Affero General Public License v3.0
6 stars 15 forks source link

Issue 347 #370

Closed wiltonsr closed 8 years ago

rafamanzo commented 8 years ago

Welcome!

Nice contributions. Congratulations :) Let's just wait for Travis

I understand that both the modifications are small and easy to review as a whole. In the future (you can leave this PR as it is), please have in mind that to try to:

rafamanzo commented 8 years ago

Regarging the failling test, could you test it using the following step?

When(/^I set the date select fields to today$/) do
  step "I set the select field \"day\" as \"#{Date.today.day}\""
  step "I set the select field \"month\" as \"#{Date.today.month}\""
  step "I set the select field \"year\" as \"#{Date.today.year}\""
end
rafamanzo commented 8 years ago

Looks like the acceptance test still has issues with the new dates form :/

https://travis-ci.org/mezuro/prezento/jobs/158592168#L2805

wiltonsr commented 8 years ago

Making the PR more coherent. Removing the data form fixes and pushing only the code about this issue.