mezz / ItemZoom

Minecraft Mod that shows a big version of the item you hover over.
MIT License
13 stars 7 forks source link

Several improvements to the U.S. English translation and config file descriptions #34

Closed Eric-01 closed 2 years ago

Eric-01 commented 2 years ago

For some time now, JEI has had not only the ingredient list overlay but also the bookmark overlay. Since ItemZoom works with the ingredient list overlay only, I made it clear how it works. (Isn't it a bug, though?)

Additionally, in e4389f526e717e4ec3c252fe7a2dd7e8ceb8f393 two new strings have been added, but possibly due to a copy-paste mistake, their IDs in the English translation file were not what they should be.

mezz commented 2 years ago

Thanks for contributing! ItemZoom should work with JEI bookmarks since version 2.4.1, are you having issues with it?

Eric-01 commented 2 years ago

It must have been some kind of mod incompatibility, as I've just checked in a clean install and ItemZoom works when hovering over both the JEI ingredient list overlay and the bookmark overlay. I'm sorry for the trouble.

mezz commented 2 years ago

No problem! Thank you for confirming.