JEI has been hacked (there is a Go Vote Screen)

[BaccarWozat]

Some idiot has hacked the mod and put political spam in it. I would be more careful accepting pull requests in future.

[l-Luna]

do you understand how git works

[ChloeDawn]

This is an intentional addition, JEI has not been hacked. Go and vote ❤️

[Vazkii]

[tomdodd4598]

I've been trying to do the calculations, but I'm running out of paper and my pencil grows blunt. Gonna have to go to W H Smiths to get some more, but so far a mixture of lemmas and half-proofs suggests tentatively that one can buy a keyboard, or indeed plug one in if you already have one lying around somewhere, and hit the little 'Esc' button to move onto the game.

Again, this is early results, don't go to the media about it yet and keep all evidence for and against this ongoing work objective as best you can. Thanks for your patience!

[cerovest]

just vote

[DoomSquirter]

how bout we do both? we all go vote, AND we keep the political bullshit out of minecraft, hmm?

[ghost]

as an american, here's a fun thing i suggest doing;

don't remove messages telling my people to vote :V

[CammiePone]

as an American, someone who hates going places, and someone who dislikes the whole political system:

just go vote if you're old enough. Like, geez my dude, it's a one-time screen, just get over it if you don't want to see it. The only people complaining about politics in games always seems to be the ones who don't constantly live in fear of their rights being stripped from them due to centuries old bigotry. If that's not you, then you should be advocating for this stuff. If that is you, then you should still be advocating for this stuff. It doesn't end at politics, it encompasses people's lives and livelihoods, and it doesn't matter who you are, you should care about protecting those.

[DaMatrix]

i don't understand the point of these things. every single time, 99% of the reactions are either people being triggered about it being there, or people insisting it's not a big deal.

of the remaining 1%, how many are going to be starting up their minecraft modpack, see this popup and go "oh yeah, i need to vote! nobody has reminded me to do that yet, and this reminder from my block game mod has totally motivated me to get off my lazy ass and go do that" vs "i wasn't planning on voting before, and this reminder just interrupted me while i was about to start playing with my virtual legos, so i'm still not gonna vote. lol"?

how many people (who wouldn't have voted otherwise) are really going to see this and go vote? probably nobody. how many people are going to be triggered about it? a lot. how many people are going to see the people getting triggered about it and get triggered back at them? also a lot. what is the outcome that is in all circumstances, practically 100% guaranteed? the result of the vote doesn't change at all, but you managed to get a bunch of people yelling at each other.

real-world politics do not belong in a video game. period.

[DoomSquirter]

it's the literal definition of an advertisement, regardless of any good intentions or not. I don't want my minority report in my minecraft tyvm. I wanna build a house out of blocks, feed my pet cat blocky fish, ride a blocky horse and fuck a blocky pig. and I don't wanna be interupted doing any of those things by any ads.

[TheCodedOne]

While I find the go vote screen obnoxious & pointless, I believe overall it is fine, however, I'd say that doing https://github.com/mezz/JustEnoughItems/blob/713f6776479e4fda633ed324388c10174ca1f5bb/src/main/java/mezz/jei/vote/GoVotePlugin.java#L28-L36 where it tells you to vote for a specific candidate, is beyond stupid

[l-Luna]

unless you vote in the pedophile the other pedophile will win, besides, everyone knows that the constitution can never be overruled just ask the folks at gitmo

one pedo who's halfway through breaking your democracy vs another who hasn't started, and also has somewhat better policies

it's the literal definition of an advertisement, regardless of any good intentions or not. I don't want my minority report in my minecraft tyvm. I wanna build a house out of blocks, feed my pet cat blocky fish, ride a blocky horse and fuck a blocky pig. and I don't wanna be interupted doing any of those things by any ads.

you can do that without JEI if you like. you're the one choosing to use this, and you are entitled to nothing. this mod was not made for you to be able to it ore the world around you like this.

real-world politics do not belong in a video game. period.

wait until you hear about basically every other video game
or even just Minecraft china

[nea89o]

the pedo with the better politics

at least you are admitting you're a retard.

[DaMatrix]

wait until you hear about basically every other video game

did i say that it was acceptable in any other video game? it's just as bad anywhere else, but we aren't talking about other video games. we're talking about minecraft - or rather a specific minecraft mod.<

if you think trump's breaking the democracy you are...

can we stay on-topic pls, this issue is related to a vote reminder popup, not a comparison of the various presidential candidates

[nea89o]

can we stay on-topic pls, this issue is related to a vote reminder popup, not a comparison of the various presidential candidates

well it was until there is actually code in here supporting one of the two candidate explicitely

[nea89o]

Btw is this regional or do i also get this as EU citizen?

Edit: yes it is. Thanks :)

[DaMatrix]

it's based on the default system locale. you'll only get it if your system language is set to *_US

or more specifically, one of:

• en_US
• es_US
• zh_US
• tl_US
• vi_US
• fr_US

[quat1024]

Hoes mad

[shedaniel]

You telling us to vote is fine, however, the following is not.

---

The code responsible for this is at: https://github.com/mezz/JustEnoughItems/blob/713f6776479e4fda633ed324388c10174ca1f5bb/src/main/java/mezz/jei/vote/GoVotePlugin.java#L30-L33

[mezz]

Thanks for the report! You can rest assured that JEI has not been hacked. The commit to add the "Go Vote" message is from me and intentional. I cryptographically sign all my commits so that you can verify it's actually from me by viewing the commit here on GitHub:

I hid the disturbing conspiracy-probably-chinese-nationalist-propoganda comments in the thread from ConnieCommie, that was weird and not welcome.

If you would like to talk about the political support for Joe Biden, keep in mind that's much less visible and more of an easter-egg. I think that's a bit off topic for this thread and Github isn't the best place for it. We can take the discussion to the best platform ever created for political debate (as endorsed by our current president and leader of the free world): Twitter. https://twitter.com/mezz_mc/status/1307503088245202944

[CammiePone]

I'm just going to leave this here

[Martmists-GH]

it's based on the default system locale. you'll only get it if your system language is set to *_US

or more specifically, one of:

• en_US
• es_US
• zh_US
• tl_US
• vi_US
• fr_US

This is such a stupid idea. Putting aside that telling people to vote for a specific person is generally a bad idea or even that politics ideally shouldn't be discussed in games, many users that prefer to have their language set to english use en_US, because this also avoids contracting special characters. Locale should not be an indicator of what country someone resides in. Instead, something as simple as a geoip check or similar could be used, with the caveat that people using a VPN are caught in this too, but that is something users with a VPN often expect.

I'd also like to note that claiming Twitter is a good platform for discussion is an awful statement looking at the history of people simply shouting at each other with zero interest of listening. (Case in point being the current POTUS)

[mezz]

This is based on the system locale, not the game locale. I can add a geoip check to make it more accurate. If someone is caught by this with a VPN they can hit ESC as easily as anyone else, sorry if you see it by accident.

Twitter is an awful platform but if people want to shout then that's the place. Actual issues and improvements like you've highlighted are welcome here.

[Martmists-GH]

A decent reference for IP-based checks can be found in Patchouli's source code, from a quick search: Patchouli

[mezz]

I have implemented the geo-ip check to bring this more in-line with the other mods.

[Skizzles]

@mezz Honestly keep politics out of the mod community and mc community as a whole. People like you are the problem, and you even used it to put support for Joe Biden. Consider your mod uninstalled.

[mDiyo]

This message constitutes a full-screen advertisement and spam in a game that has none of those things. Regardless of the message, this is the worst way to communicate with your users. I can tell you from personal experience that you do NOT want this in your mod.

[mezz]

Thanks for the advice but I’m not sure I agree with the premise.

[mDiyo]

How can we trust you not to put other advertisements in the game? What's stopping you from throwing up banner ads for Raid: Shadow Legends, or putting in a litecoin miner somewhere?

The issue here is trust. You do not want to burn what inherent trust you have with your users. Take it out before anyone who doesn't want the real world in their block game drops Just Enough Items like a rock.

[mezz]

I posted some more context here:

https://github.com/mezz/JustEnoughItems/commit/3fb4b9aea9e4b958b1a2f70202713df1e4b412c4#r42521557

These are truly exceptional circumstances and based on how I have run the mod for years, I hope I have built up enough of your trust that you will look for the reasoning and ask for justification in good faith instead of assuming the worst of my judgement.

[mDiyo]

Before today I didn't know anything about you other than that you wrote this mod, and that the mod is useful. Now I know one more thing: I do not trust you to keep your mod clean of the outside world, ads, or other scummy practices.

Consider this final notice that JEI will not be supported by me. Real life does not belong in a game where we get to build cool things out of floating blocks.

[TelepathicGrunt]

@mDiyo Final notice? You do understand no one really cares about a single user not using a mod? That's like going to a store and shouting "I won't shop here anymore!" despite the fact that literally nothing will change if that customer never comes back. Zero impact.

Please stop dramatizing yourself. Please go vote or take off JEI. No one is forcing you to do anything and you have no influence over what modders do in their FREE mod in their free time.

[Mysticpasta1]

So will this go vote thing be removed after the election if so I think we can put up with it for 2 months. If not then there is a problem seeing it after the election is over and someone has won!

[CursedFlames]

!isAfterElectionDay() @Mysticpasta1 looks like there's a check for it.

[Vazkii]

@mDiyo bye no one will miss you

[jamierocks]

Would it be possible to not create the marker file in countries that aren't the USA?

[zabi94]

How can we trust you not to put other advertisements in the game? What's stopping you from throwing up banner ads for Raid: Shadow Legends, or putting in a litecoin miner somewhere?

Ah yes the good ol' slippery slope, lovely.

[Devan-Kerman]

How can we trust you not to put other advertisements in the game? What's stopping you from throwing up banner ads for Raid: Shadow Legends, or putting in a litecoin miner somewhere?

hey what's wrong with that

[Vazkii]

Would it be possible to not create the marker file in countries that aren't the USA?

Hi, this was my decision.

Creating the marker file expedites the process of loading the screen. Since the file is there we don't have to actually run the check of whether you're in the US or not. Considering many mods have this code, it's a lot faster to check the file existence than have each mod spin their own thread to check your location.

[jamierocks]

Since the file is there we don't have to actually run the check of whether you're in the US or not.

That isn't the case with JEI, though it does seem that Patchouli short-circuits - that change should be made here.

[Vazkii]

I recommend you open that as a separate issue.

[Waisse]

Adding a reminder to vote is one thing, but chilling your candidate of choice is another. Remove the Biden item.

[jamierocks]

Adding a reminder to vote is one thing, but chilling your candidate of choice is another. Remove the Biden item.

See https://github.com/mezz/JustEnoughItems/commit/3fb4b9aea9e4b958b1a2f70202713df1e4b412c4#r42522566 for some context on this. I would still rather go the route of educating players than pushing a single candidate on them, allow people to come to their own (educated) decision - but this is mezz's mod, and I figure he is from the USofA.

[Waisse]

Adding a reminder to vote is one thing, but chilling your candidate of choice is another. Remove the Biden item.

See 3fb4b9a#r42522566 for some context on this. I would still rather go the route of educating players than pushing a single candidate on them, allow people to come to their own (educated) decision - but this is mezz's mod, and I figure he is from the USofA.

I don't want context, I want impartiality.

[Wazubaba]

You know, it's funny. If I wasn't so poor I'd be willing to bet money that if a Trump-supporting mod author did this the same people in this thread defending this nonsense here would be there screaming foul there with a complete lack of self-awareness, and yet likely most of the people screaming foul here currently would still be screaming foul there as well. Note the difference.

[CammiePone]

You know, it's funny. If I wasn't so poor I'd be willing to bet money that if a Trump-supporting mod author did this the same people in this thread defending this nonsense here would be there screaming foul there with a complete lack of self-awareness, and yet likely most of the people screaming foul here currently would still be screaming foul there as well. Note the difference.

The difference is Trump wants, and has been, stripping rights away from people. While Biden still sucks, at least we'll survive him. Trump? Good chance more people will be rounded up into concentration camps. Complaining about "uh muh escape from reality" when there are people that don't have that luxury just shows how priviliged you are.

[Wazubaba]

No. This has nothing to do with Trump. This has nothing to do with Biden. Nobody wants to deal with all of you folks who have to inject politics into every fathomable thing you touch - regardless of which side of the same coin you guys are on.

We want to enjoy minecraft and forget about our worries for just a few hours before having to clock in to our jobs that are driving us to an early grave, or schools that aren't teaching us anything that can actually help us as adults.

[CammiePone]

Complaining about "uh muh escape from reality" when there are people that don't have that luxury just shows how priviliged you are.

Thank you for literally proving my point.

[Wazubaba]

And thank you for proving mine.

[Thaums]

I don't normally vote but seeing this convinced me to vote Trump. Thanks mezz!!!