mezz / JustEnoughItems

Item and Recipe viewing mod for Minecraft
https://www.curseforge.com/minecraft/mc-mods/jei
MIT License
786 stars 305 forks source link

Add another search filter, * for light level #363

Open Prospector opened 8 years ago

Prospector commented 8 years ago

Sometimes it's hard to find blocks with lighting for a build. Could be useful, if we could just do something like "" for all blocks with light value, and "[number]" to specify the light value to search for.

kraineff commented 8 years ago

+

mezz commented 8 years ago

That's an interesting idea but it would not be able to detect lights that require redstone to activate.

Prospector commented 8 years ago

True, but it would still be useful for some things. Perhaps mods using the api can specify that a block (or item, like in dynamic lighting's case) can output light, and under what conditions (can be displayed in tooltip maybe)

mezz commented 8 years ago

I think this idea would be more useful as part of a mod that adds light levels to tooltips, then JEI could search the tooltip for it and you can see the specific light level on the tooltip.

KnightMiner commented 8 years ago

The problem I see with placing it in the tooltip is those can get quite cluttered with all the potential information you might want to search for, light level is just one example along side flamability or transparency, plus if you put the data in the tooltip it could become hard to tell whether the block has a light level, or just references light in a different way (eg, special transparency, color, specifically stating no light level, etc.) Basically, it would be nice to have a clean way to do some of those without depending on a string that may exist elsewhere.

So what about if the idea is expanded to do more than just a single task? Basically, the * character would check for a pre-made category of items instead of just light level. As in, *light searches for blocks that emit light, *food searches for items that can be eaten, etc. On top of this, maybe add an API for mods to add their own categories for this search (like Tinkers Construct tool parts as an example) or to add items to an existing category that don't fit the dynamic criteria (like a vanilla redstone lamp that the block technically does not emit light, but in world interactions cause it to). The idea would be searching for something as a human you know is true, but cannot otherwise be searched for in JEI

It shouldn't impact performance too much overall if implemented, such as by creating a cached list once on startup.


I would understand if this idea is better suited for an addon, though does JEI support addons defining custom search strings prefixes? It would be hard to add if that features does not exist.

Prospector commented 8 years ago

ooh I like that idea. A general "type" filter

GalexY727 commented 4 months ago

I am going to bump this from it's eight-year slumber because I love light level emitting blocks 🙂

J4yd3n222 commented 3 months ago

Bumping as well. I've had dozens of times where I would've used this, because I needed some form of luminous block for a build and wanted to compare all them

KnightMiner commented 3 months ago

My thoughts upon revisiting this issue is * should not be used for this. Different character is reasonable, but * is used in many searches to indicate "wildcard" value, which would both be misleading and potentially prevent such a feature from being added in the future (unless it already exists, been too long since I tried)

GalexY727 commented 3 months ago

Different character is reasonable...

That's completely understandable. Perhaps something strange such as [? Maybe =... I don't know off the top of my head if these are already used.