mezz / JustEnoughItems

Item and Recipe viewing mod for Minecraft
https://www.curseforge.com/minecraft/mc-mods/jei
MIT License
778 stars 303 forks source link

[Bug]: Visual Bug when hovering the "+" button in Refined Storage #3630

Open AFKafe opened 2 months ago

AFKafe commented 2 months ago

Steps to Reproduce the Bug

  1. Have a Refined Storage system
  2. Check a craft with JEI when you're in RS
  3. Hover the "+" button 3_1. When you have items, no problem 3_2. When you don't have items or when you have a pattern for one of the crafted items

Exemple here : Bug JEI - Refined

Expected Behavior

The elements at the edge of the craft window (categories, etc.) don't move elsewhere on the interface when hovering over the "+" button when you are in one of these situations: "don't have any objects for crafting" or "have a pattern for one of the elements of the items"

Actual Behavior

The elements at the edge of the craft window (categories, etc.) move elsewhere on the interface when hovering over the "+" button when you are in one of these situations: "don't have any objects for crafting" or "have a pattern for one of the elements of the items"

Mod Pack URL (Optional)

No response

Mod Pack Version (Optional)

No response

Extra Notes (Optional)

Tested on a Modpack in 1.20.1 (Forge 47.3.0) created for testing this bug without other mods.

Modlist :

latest.log

https://gist.github.com/AFKafe/95a12e343c0ff3b09ddcdbddea9130be

mezz commented 2 months ago

Thanks for the report!

It looks like RS does something that leaves everything shifted: https://github.com/refinedmods/refinedstorage/blob/112771d91adff594fae5d499708e700f9dc8ec3e/src/main/java/com/refinedmods/refinedstorage/integration/jei/RecipeTransferCraftingGridError.java#L40-L45

They should have a pushPose and popPose around that code in order to avoid leaking the translation. Please report this to Refined Storage and link back to this issue.

I will add some defensive code to JEI to help mitigate the problem too.

mezz commented 2 months ago

I opened a PR with RS to fix the issue here:

AFKafe commented 2 months ago

Sorry for the delay, thanks for opening the PR.

Keep up the great work and thanks for your mods!