search

mezz / JustEnoughItems

Item and Recipe viewing mod for Minecraft
https://www.curseforge.com/minecraft/mc-mods/jei
MIT License
771 stars 301 forks source link

[Bug]: Neoforge 1.21.1 Some Items in creative menu are not being added to JEI #3723

Closed Saereth closed 2 weeks ago

Saereth commented 2 weeks ago

Steps to Reproduce the Bug

Install a new instance of Neoforge 21.1.31 add JEI 19.14.2.146 add some of SuperMartijn642's mods and dependencies such as trashcans, entangled, item collectors mods

The mod adds the items to the creative tab but they never show up in JEI.

Expected Behavior

I would expect the items to show up in JEi

Actual Behavior

They only show in the creative tab

Mod Pack URL (Optional)

No response

Mod Pack Version (Optional)

No response

Extra Notes (Optional)

I originally opened an issue with SuperMartijn642 here: https://github.com/SuperMartijn642/TrashCans/issues/46 but as this was suspected to be a JEI issue or unexpected behavior I've opened it here for followup. If I can provide any more logs or testing let me know and I'm glad to help. Thanks!

latest.log

No response

mezz commented 2 weeks ago

Thanks for the report! SuperMartijn642's explanation was clear and this should be fixed in the next release of JEI (available shortly).

mezz commented 1 week ago

The previous fix wasn't working. This actually turned out to be a different issue entirely!

@SuperMartijn642 adds his items to the creative tab using TabVisibility.PARENT_TAB_ONLY (see here) and JEI was only looking for items included in the search tab. I have updated JEI to look in both places.

This has been fixed in JEI 19.17.0.195