mezz / JustEnoughItems

Item and Recipe viewing mod for Minecraft
https://www.curseforge.com/minecraft/mc-mods/jei
MIT License
784 stars 306 forks source link

[Bug]: Not showing any of potion fluids from Create mod #3754

Closed goshante closed 1 month ago

goshante commented 1 month ago

Steps to Reproduce the Bug

  1. Open Minecraft 1.20.1 with latest Forge (not NeoForge) version available for it. It should have JEI and Create mods installed (latest versions available from Curse).
  2. Load your world or join the server
  3. Open JEI interface to search for an item
  4. Search for any potion

Expected Behavior

You can see all bottled potions and their fluid versions when playing with Create mod. Every potion must have it's fluid representation in JEI interface (even if no existing crafting/processing recipes).

Actual Behavior

Only bottled potions are visible, no fluids at all. Enabling lookupFluidContentsEnabled and ShowHiddenItems in config also doesn't helps.

Mod Pack URL (Optional)

No response

Mod Pack Version (Optional)

No response

Extra Notes (Optional)

Why this is so necessary: For example, when playing with Applied Energistics 2 the only way to make Crafting pattern with fluids is to drag & drop fluid icon from JEI interface (Dragging from ME interface is not possible for fluids). You can drag water, lava or milk from JEI to AE2 Crafting pattern encoder and it works, but it's impossible to do with potion fluids from Create because they don't exist for JEI and not indexed in item list. But Potion fluids are exist in game, they show up in storage, you can see icons of potion fluids and stored volume, but none of them is visible in JEI interface. You cannot also configure Export and Storage buses, because you cannot drag a liquid into filter grid.

With AE2 or without, JEI have to show all potion liquids if they are the thing in Create mod.

latest.log

No response

mezz commented 1 month ago

Thanks for the report! I looked into this, and it seems like almost all of Create's fluids are "flowing". JEI only shows "source" fluids right now. I'll see how I can add better support for this.

mezz commented 1 month ago

I updated JEI a bit and made a pull request to Create in order to complete the feature: https://github.com/Creators-of-Create/Create/pull/6934 It will be available for players if they review and accept the PR.

2024-09-12_16 52 24

goshante commented 1 month ago

Thank you, it works! I tested your changes They will review and merge your pull request soon as new patch will be on plans, I asked about it