Closed Greg-21 closed 2 months ago
Thank you for diligently going through to fix these up, and documenting your changes in the PR description here. Rest assured your effort is appreciated!
I looked through and the changes all look very positive (or at least neutral), so I have no problem merging these in. Thanks again!
Would you be interested in having me port this fairly large set of changes to the older Minecraft versions you still support?
It wouldn’t be much of an issue on my end, as most of the porting process can be automated, and I already have the required scripts for this task.
Thank you, that would be appreciated.
@Greg-21 I have re-implemented the localization for config files in this commit: https://github.com/mezz/JustEnoughItems/commit/719c00ecc104fa53d46db0fc7dc6f02f246385cc
I haven't removed all the old unused values yet, because I may need them when I implement a config GUI soon. I just wanted to give you a heads up in case you were planning on doing anything with them.
As far as I'm concerned, feel free to remove whatever you want. If I need anything in the future, I can always branch off from any commit and start from there.
EDIT: Now that you mention it, I think I'll also remove all the remnants of the old in-game configuration interface from the older Minecraft versions if you plan to do the same in the current one.
The changes I've made include various improvements to the source U.S. English translation, enhancements to the comments in the configuration files to make them at least a bit more clear and helpful (I hope), and last but not least, an overall cleanup of the rest of the translations to align them better with the current U.S. English translation and make it easier for future translators to pick up where their predecessors left off and continue from there.
I realize that what seems like a positive change to me, may actually be the opposite, so I'm open to all kinds of criticism and comments. After all, this is your mod and your repository (not mine), and without it, I could do nothing more than flip through pages for 40 days and 40 nights in the Risugami's Recipe Book like in the good old days :)
This pull request consists of three main parts (one commit for each of these points):
jei.tooltip.error.recipe.transfer.unknown
andjei.tooltip.error.recipe.transfer.disabled
have been removed, as they haven't been in use for 8 (!) and 3 years respectively. The code associated with the former has been removed in commit 9097e16723308d79acf9fef5cdb54604231502a5, and the code for the latter in commit f8e5522d851126d14c716254a4a6e7a524eb47ce (only 20 minutes after the feature was introduced, just a little fun fact).nb_no.json
tono_no.json
, since the latter is the correct locale code used in Java Edition for this language. It has been the case for a while now, but apparently no one has noticed, or the absence of this translation hasn't been significant enough for anyone to contribute a fix.The list above is not exhaustive and doesn't cover all the changes, only the most significant ones (and even then, it's long enough that a TL;DR would be handy, so I'm not making it any longer).