mezz / JustEnoughItems

Item and Recipe viewing mod for Minecraft
https://www.curseforge.com/minecraft/mc-mods/jei
MIT License
776 stars 302 forks source link

[Crash]: Moving the items into the crafting table of the backpack with JEI #3785

Open HenrikoMagnifico opened 5 days ago

HenrikoMagnifico commented 5 days ago

Steps to Reproduce the Crash

Moving items into a crafting table of a backpack from Sophisticated Backpacks with JEI causes the client to crash.

Steps to reproduce:

  1. Create Creative World
  2. Give youself a backback, a crafting upgrade and a stack of logs
  3. Open backpack and open crafting interface.
  4. An JEI check the recipe for planks and click [+]

Mod Pack URL (Optional)

https://www.technicpack.net/modpack/henrikocraft.1996032

Mod Pack Version (Optional)

1.0.0 Beta 5

Extra Notes (Optional)

No response

Crash Report

https://gist.github.com/HenrikoMagnifico/30c4898e1054dd0ff5625d4f4a48b4c9

2amzicholas commented 5 days ago

I too am having this issue when JEI, EMI, and Sophisticated Storage/Backpacks are installed. MC Version 1.20.1 / Forge JEI 15.19.5.99 (latest) EMI 1.1.13 (latest) Sophisticated Backpacks 3.20.6.1064 (NOT latest) The following crash occurs when trying to autofill a recipe into the Sophisticated Backpacks crafting grid from either EMI or JEI: https://mclo.gs/G6sGQSn

Mod pack is All The Mods 9 with updated client mods (specific versions above) and EMI installed. Other non-default client mods are also installed.

mezz commented 3 days ago

Thanks for the report! Please report the problem to Sophisticated Backpacks and link back to this issue: https://github.com/P3pp3rF1y/SophisticatedBackpacks/issues

2amzicholas commented 3 days ago

No other changes made, reverting to JEI 15.12.2.51 fixed the issue for me. I think the issue snuck by in an update between 15.12.2.51 and 15.19.5.99, which is a wide scope, but I suggest you check the most recent versions first. Let me know if I can be more helpful; I've never made a bug report before.

mezz commented 3 days ago

For more context, Sophisticated Backpacks is using an internal JEI class which changed in the later versions of JEI. This breaks the normal contract between the mods, ideally they should depend on the JEI API which is stable. Sometimes JEI doesn't provide the methods that other mods need so they use internal classes, but it's up to them to resolve the issue.

I can help out or provide new APIs to support their use case, but the first step here is to open a bug report and let them know there's a problem, so they can use their best judgement for how to resolve it.