search

mezz64 / pyEight

Python library to interface with the Eight Sleep API
MIT License
59 stars 15 forks source link

Add tests for pyeight.eight and pyeight.user #25

Closed raman325 closed 2 years ago

raman325 commented 2 years ago

I made minimal changes here to get pylint to pass. Next step after merge would be to simplify some of the logic, to add type hints, and to improve coverage

raman325 commented 2 years ago

I also added another round of tests to improve coverage and this is my final list commit on this PR. This will help ensure that when I make a bunch of changes to the code (already ready and I am testing it against these tests), the test case changes should be minimal and deliberate in that I think the changed behavior is the better behavior in those cases

mezz64 commented 2 years ago

This all looks good and functionality tests out OK in my dev environment. Only thing I'd ask you to do before I merge is change your email in the test_eight.py and test_user.py files to the mock email (johndoe@gmail.com) you have defined in the fixtures.

raman325 commented 2 years ago

good call, that was meant to be a placeholder and I certainly don't want my email in there 🙂

mezz64 commented 2 years ago

good call, that was meant to be a placeholder and I certainly don't want my email in there 🙂

I figured. There are still a few more instances. I marked them in review so you can find them easily.

raman325 commented 2 years ago

thanks forgot to hit save before committing 🤦🏾