search

mezz64 / pyHik

Python wrapper for Hikvision camera event stream
MIT License
180 stars 50 forks source link

Added support for new ISAPI urls #49

Open ayushpratap opened 4 years ago

ayushpratap commented 4 years ago

get_device_status get_device_time get_get_upnp_ports_status

ayushpratap commented 4 years ago

I have tested these changes with two Hikvision DVRs I have with, cameras of Hikvision, CP Plus, Dahua.,

mezz64 commented 4 years ago

I'm on board with the new endpoints, but things need streamlined a bit. The current intent of the library is that initialize is always called first which should define some of the items you are repeating in each function (digest check in particular). I also don't see the need to add the beautiful soup dependency when everything can be done with the existing XML tree functions.

ayushpratap commented 4 years ago

@mezz64 Okay we can streamline the library. I used beautiful soup because of its flexibility and ease of use. Drop me a mail with your approach on ayushs56@gmail and we can move forward from there

ayushpratap commented 4 years ago

I have removed the BeautifulSoup dependency from the new added URLs