search

mezzio / mezzio-hal

Hypertext Application Language implementation for PHP and PSR-7
https://docs.mezzio.dev/mezzio-hal/
BSD 3-Clause "New" or "Revised" License
19 stars 21 forks source link

PSR-17 support #46

Closed tobias-trozowski closed 2 years ago

tobias-trozowski commented 2 years ago
Q A
BC Break no
New Feature yes

Description

Based on @boesing's work from his PSR-17 support #43 PR.

This PR is going to provide an integration with PSR-17: HTTP Factories.

froschdesign commented 2 years ago

This PR is going to provide an integration with PSR-17: HTTP Factories.

This also means that the documentation must be updated and the readme file, repository description, etc. This also has a promotional character when we can say that this package supports various PSR standards.

weierophinney commented 2 years ago

@tobias-trozowski Can you rebase from #43, please? I've provided a number of changes there since rebasing, and I'd like to get an idea how much the two of these patches differ.

What is the key difference with your patch, versus the one submitted by @boesing?

boesing commented 2 years ago

@weierophinney I actually don't have time to work on this and thus I suggested to use my initial work as a base for further enhancements regarding public methods which are marked internal.

tobias-trozowski commented 2 years ago

@weierophinney i removed the getters which were only used to assert them in tests. already rebased against 2.3.x.

weierophinney commented 2 years ago

I've rebased to pick up the bump to PHP 7.4, and the additional Psalm fixes I performed yesterday. I'll get documentation updated in a few hours so this can be completed.

weierophinney commented 2 years ago

@froschdesign I'll give you a chance to review the documentation changes before I merge. They're primarily in:

(The other doc changes were due to linting errors; I didn't want to create a new PR to fix those and have to rebase this one again.)