search

mezzio / mezzio-laminasviewrenderer

laminas-view PhpRenderer integration for Mezzio
https://docs.mezzio.dev/mezzio/features/template/laminas-view/
BSD 3-Clause "New" or "Revised" License
6 stars 12 forks source link

Merge 2.4.0 into 3.0.x #16

Closed gsteel closed 2 years ago

gsteel commented 2 years ago

Closes #15

Resets composer.* to 2.4.x. Resolves conflicts in test case.

gsteel commented 2 years ago

Oh, fun:

Error: Argument 1 of Laminas\View\HelperPluginManager::__construct expects Interop\Container\ContainerInterface|Laminas\View\ConfigInterface|null, parent type Psr\Container\ContainerInterface provided (see https://psalm.dev/193)

🤔

Yeah… This needs suppressing I think because it simply isn't an Interop instance, but, the helper manager won't complain - Laminas View needs updating I guess??

boesing commented 2 years ago

Yeah… This needs suppressing I think because it simply isn't an Interop instance, but, the helper manager won't complain - Laminas View needs updating I guess??

It actually won't. but imho worth changing the docblock in laminas-view while conflicting with container-interop <1.2 (which introduced the PSR interface)