search

mezzio / mezzio-migration

Migrate Mezzio applications from v2 to v3
https://docs.mezzio.dev/mezzio/
BSD 3-Clause "New" or "Revised" License
3 stars 4 forks source link

Psalm integration #15

Closed jslmorrison closed 2 years ago

jslmorrison commented 2 years ago
Q A
Documentation no
Bugfix no
BC Break /no
New Feature yes/
RFC no
QA yes

Description

Add vimeo/psalm integration.

Ocramius commented 2 years ago

See CI failures: the generated baseline is missing most reported errors 🤔

jslmorrison commented 2 years ago

See CI failures: the generated baseline is missing most reported errors

Hi - I don't see these errors when running static-analysis locally. Do you want them suppressed by expanding the baseline in the following manner?

<PropertyNotSetInConstructor>
    <errorLevel type="suppress">
        <referencedProperty name="Mezzio\Migration\MigrateCommand::$input" />
    </errorLevel>
</PropertyNotSetInConstructor>
Ocramius commented 2 years ago

No, they should just appear as "known issues" in the baseline 🤔

Check what CI did run here: possibly some differences between local setup and this?