search

mezzio / mezzio-skeleton

Laminas mezzio skeleton. Begin developing PSR-15 middleware applications in seconds!
https://docs.mezzio.dev/mezzio/
BSD 3-Clause "New" or "Revised" License
120 stars 32 forks source link

Remove unintentionally undelivered `phpunit.xml.dist` from `export-ignore` #114

Closed zonuexe closed 1 year ago

zonuexe commented 1 year ago
Q A
Documentation no
Bugfix yes
BC Break no
New Feature no
RFC no
QA no

Description

closes https://github.com/mezzio/mezzio-skeleton/issues/109 It was unintentionally missing from the distribution files at https://github.com/mezzio/mezzio-skeleton/pull/97.

I have checked that the following script does not generate any errors.

git clean -f .
git restore .
rm -r .gitattributes .github .laminas-ci.json phpcs.xml.dist phpunit.xml.dist psalm.xml.dist psalm-baseline.xml renovate.json

yes 1 | composer install

Fixes #109

Ocramius commented 1 year ago

I suppose this fixes #109?

zonuexe commented 1 year ago

@Ocramius

Yes, I confirmed the operation by the method written in the PR description.

I've temporarily published the forked repository to Packagist, so the command below should also work.

composer create-project zonuexe/mezzio-skeleton-test mezzio
zonuexe commented 1 year ago

It probably makes sense to add a command like the following to CI to test skeleton project.

git archive HEAD --worktree-attributes -o archive.tar
(mkdir unarchived && cd unarchived && tar xf ../archive.tar && test -f composer.json && yes 1 | composer install)
Ocramius commented 1 year ago

@zonuexe ack, CI additions would be nice, so feel free to throw them this way, but meanwhile, I'm merging + releasing this, thank you!