search

mezzio / mezzio-swoole

Swoole support for Mezzio
https://docs.mezzio.dev/mezzio-swoole/
BSD 3-Clause "New" or "Revised" License
87 stars 28 forks source link

Prepare for working with newer versions of OpenSwoole. #128

Open slaff opened 7 months ago

slaff commented 7 months ago
Q A
Documentation no
Bugfix yes
BC Break no
New Feature yes
RFC no
QA no

Make Mezzio Compatible with OpenSwoole v 22.0 and newer

This PR adds initial compatibility with OpenSwoole v22.0 and newer. The changes in the PR are inspired by @Xerkus work and all credit goes to him. This PR is related to #110.

TODO

Xerkus commented 7 months ago

I don't think changing autoloading rules affects lock file. Those fields are not used for hash afaik

Xerkus commented 7 months ago

@slaff I am not an author here, btw.

slaff commented 7 months ago

I am not an author here, btw.

@Xerkus thank you anyway. If you can, please, tell me whom shall I credit and I will put their names.

madalinignisca commented 7 months ago

I am confused as to why the project is introducing a compatibility layer for the current version of OpenSwoole, and it is not refactoring to continue 1st party with OpenSwoole, and add a compatibility layer in case Swoole is used, if the effort is worth it.

The Mezzio Swoole documentation instructs users to use OpenSwoole, not Swoole.

If OpenSwoole 24.x, 26.x will diverge more from Swoole (which will happen), wouldn't users be aware that the package is focused on Swoole, opposite to what they are instructed by docs for OpenSwoole?

I'd be happy to see the package in newer versions requiring openswoole > 22.

slaff commented 7 months ago

I'd be happy to see the package in newer versions requiring openswoole > 22.

Me too. But it is up to the project leaders and contributors to decide which direction to go.