search

mezzoblue / csszengarden.com

The source of csszengarden.com
Other
1.88k stars 587 forks source link

mod_rewrite funkiness #78

Open mezzoblue opened 10 years ago

mezzoblue commented 10 years ago

After publishing the new mod_rewrite rules a few previously unnoticed issues have come up.

http://www.csszengarden.com/?cssfile=http://www.skybased.com/css-zen-garden/css/screen.css

http://csszengarden.com/legacy/?cssfile=http://www.brucelawson.co.uk/zen/sample.css/

eyesofjeremy commented 10 years ago

Good to know. Also, an older-style URL (http://www.csszengarden.com/?cssfile=/216/216.css) resolves incorrectly to http://www.csszengarden.com/216// (note the second slash). My guess is this issue is unrelated, but at any rate, it's all in voodoo-land.

I will have to get my repo up to date before I can take a look. If you see anything else, I'll be tracking this issue. Or 'watching' it... you know.

mezzoblue commented 10 years ago

Also the 'View This Design's CSS File' link is broken. Links to http://csszengarden.com/218/218/ instead of http://csszengarden.com/218/218.css, for example.

eyesofjeremy commented 10 years ago

I don't have access to my full repo yet. But looking at the code, I think fixing the 'View This Design's CSS File' link is a very small matter. I've submitted 'patch-1', but I haven't been able to test it yet.

mezzoblue commented 10 years ago

'View Design's CSS File' link issue fixed, the other two remain.

mezzoblue commented 10 years ago

We're doing pretty well with this, the main remaining issue is getting legacy CSS files linking properly, a la https://github.com/mezzoblue/csszengarden.com/pull/88#issuecomment-47313127