search

mfaerevaag / wd

:rocket: Jump to custom directories in zsh
MIT License
693 stars 45 forks source link

Add ability to delete points from fzf browse menu #124

Closed p1r473 closed 5 months ago

p1r473 commented 5 months ago

Added ability to delete points from fzf browse menu by pressing delete button This is a work in progress, please dont merge yet - trying to figure out best way to capture the output from the subshell https://github.com/junegunn/fzf/discussions/3797

p1r473 commented 5 months ago

@alpha-tango-kilo I didnt get any hits on a better way to do it so right now Im doing it the same as currently in the script - with a temp file Feel free to merge / or give feedback!

p1r473 commented 5 months ago

Its honestly so nice having an active reviewer who is fast, and a second set of eyes on everything. It is a pleasure to work with you!

alpha-tango-kilo commented 5 months ago

You're most welcome! I do what I can, even if it's passive maintenance. I know when I was first getting into open source having a really receptive & knowledgeable maintainer was super important

As a tangent, I wish shellcheck fully supported zsh, because this is the sort of thing it's absolutely brilliant for. I believe you can make it run on zsh scripts, but some language features it won't recognise/understand so it might not perform as expected. Another motivating factor for me just sticking to more vanilla bash