Increase compliance with `shellcheck` best practices

mfaerevaag / wd

:rocket: Jump to custom directories in zsh

MIT License

693 stars 45 forks source link

Increase compliance with `shellcheck` best practices #93

Closed alpha-tango-kilo closed 4 years ago

alpha-tango-kilo commented 4 years ago

Essentially I used the shellcheck tool to pick over wd and try and improve the code style, particularly robustness against whitespace. This PR therefore will solve #89.

It is worth noting shellcheck does not natively support zsh so I ran it in bash mode and simply didn't touch anything too technical in syntax which could have been zsh specific. Most of the changes therefore are just adding loads of "quotations" all over the place.

mfaerevaag commented 4 years ago

Awesome! Didn't even though of shellcheck - that's pretty nice. Though, the PR needs rebasing :disappointed:

alpha-tango-kilo commented 4 years ago

haha - deja vu! I'll get to this soon