search

mfaisalkhatri / selenium4poc

Learn Web Automation testing using Selenium Webdriver 4.
https://mfaisalkhatri.github.io
Apache License 2.0
178 stars 71 forks source link

Update docker-compose-v3.yml #72

Closed tsluyter closed 2 years ago

tsluyter commented 2 years ago

Port for Juice Shop appears to be incorrect. By default, bkiminich/juice-shop runs on 3000, not on 3001.

That is also the port indicated in your test suite definition, so this seems like a mistake.

mfaisalkhatri commented 2 years ago

This docker compose was created considering running juice shop website along with the selenium grid. I will be adding a separate docker compose file just to run juice shop website locally.

tsluyter commented 2 years ago

This docker compose was created considering running juice shop website along with the selenium grid.

I understand that, but even in that case it runs on 3000, not on 3001 right? :)

Anyway, thanks for all your hard work!