mfasiolo / mgcViz

An R package for interactive visualization of GAM models
https://mfasiolo.github.io/mgcViz/
76 stars 9 forks source link

Re-factor check.mgcv.smooth.2D and check.mgcv.smooth.MD #24

Closed mfasiolo closed 7 years ago

mfasiolo commented 7 years ago

The idea seems to be that the check.something methods are just wrappers for more specific plots. See also this issue. Hence here it would make sense to extract a gridCheck2D function from check.mgcv.smooth.2D.

Currently the problem with check.mgcv.smooth.1D and 2D is that they really check what's happening along a 1 or 2 covariates, the do not really care about the specific smooth considered.

mfasiolo commented 7 years ago

Done via layering.