mfasiolo / mgcViz

An R package for interactive visualization of GAM models
https://mfasiolo.github.io/mgcViz/
76 stars 9 forks source link

Allow bare variable names in l_XXX calls #43

Closed fabian-s closed 6 years ago

fabian-s commented 6 years ago

Thx for this great package!

I think it would be even more awesome if I didn't have to "quote" all my "variables".
check1D(v, x = x3) :+1: , check1D(v, x = "x3") :-1:

mfasiolo commented 6 years ago

Thanks, I'm glad someone is using it!

I was thinking about it, but it is a bit difficult to cover all the cases:

By using "quotes" to distinguish variables in fit$model from the global ones it is easy to cover the 4 cases, but maybe something better can be done using substitute, parse etc.

fabian-s commented 6 years ago

I see, yeah, that's (too) tough to solve....