Open sean-e-dietrich opened 7 years ago
Hi Sean,
Sorry for the delay. Can you make sure the build pass before I can merge?
See:
FILE: /home/travis/build/mfauveau/omnipay-nmi/src/Message/AbstractRequest.php
--------------------------------------------------------------------------------
FOUND 7 ERROR(S) AFFECTING 5 LINE(S)
--------------------------------------------------------------------------------
337 | ERROR | Line indented incorrectly; expected at least 8 spaces, found 6
342 | ERROR | Line indented incorrectly; expected at least 8 spaces, found 6
342 | ERROR | No space found after comma in function call
347 | ERROR | Line indented incorrectly; expected at least 8 spaces, found 6
352 | ERROR | Line indented incorrectly; expected at least 8 spaces, found 6
352 | ERROR | No space found after comma in function call
357 | ERROR | Line indented incorrectly; expected at least 8 spaces, found 6
Hey Matthieu,
I made the fixes and pushed but for some reason the build is still failing. Not sure if that is expected.
On Wed, Jan 25, 2017 at 11:55 AM, Matthieu Fauveau <notifications@github.com
wrote:
Hi Sean,
Sorry for the delay. Can you make sure the build pass before I can merge? See: FILE: /home/travis/build/mfauveau/omnipay-nmi/src/Message/ AbstractRequest.php FOUND 7 ERROR(S) AFFECTING 5 LINE(S)
337 | ERROR | Line indented incorrectly; expected at least 8 spaces, found 6 342 | ERROR | Line indented incorrectly; expected at least 8 spaces, found 6 342 | ERROR | No space found after comma in function call 347 | ERROR | Line indented incorrectly; expected at least 8 spaces, found 6 352 | ERROR | Line indented incorrectly; expected at least 8 spaces, found 6 352 | ERROR | No space found after comma in function call 357 | ERROR | Line indented incorrectly; expected at least 8 spaces, found 6
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/mfauveau/omnipay-nmi/pull/1#issuecomment-275164676, or mute the thread https://github.com/notifications/unsubscribe-auth/ABfgTPBU3e_CJQm3CqKda0drepgwwgQqks5rV36QgaJpZM4Lj1r2 .
-- Sean Dietrich | Software Developer Located in Sacramento, CA
Email: sean.e.dietrich@gmail.com Contact me on LinkedIn https://www.linkedin.com/pub/sean-dietrich/50/544/551
Looks like an issue with test cases: https://travis-ci.org/mfauveau/omnipay-nmi/jobs/195323320
Just as an FYI, from the documentation, it seems like you wouldn't really need this. If you want to test things, just use the demo account credentials instead of your regular account.
I wanted to have the ability for the test gateway to be built in so that when clients are trying to test out the system and how it is suppose to work they know exactly how the process should go, without needing to use a live credit card.