search

mfdeph / gitiles

Automatically exported from code.google.com/p/gitiles
0 stars 0 forks source link

Display diff using side by side presentation #2

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago 
Similar to how Gerrit formats a file side by side, allow viewing a modified 
text file in a side by side view.

Gerrit's method of rendering this in a 4 column table with each line being a 
new row is horrid and should be replicated. Critique and GitHub get this more 
right by rendering 4 divs in a 1 row table, enabling the user to select a 
contiguous section of source code from either side.

Original issue reported on code.google.com by dborowitz@google.com on 11 Nov 2012 at 11:17

GoogleCodeExporter commented 9 years ago 
I don't really want to reinvent the wheel here. IMHO we should reuse the side 
by side diff logic from Gerrit, but of course that's currently impossible 
because Gerrit uses GWT, and does various other things wrong. So, first let's 
fix Gerrit.

Original comment by dborowitz@google.com on 11 Nov 2012 at 11:19

GoogleCodeExporter commented 9 years ago 
Gerrit is looking at moving to Codemirror for side-by-side diffs. We should do 
that too: not too much fancy JS, hopefully largely pasting it in, I haven't 
looked. Even if not, we should be able to reuse more code because it's just the 
server-side stuff (serving diff info), no more GWT.

Original comment by dborowitz@google.com on 19 Jun 2013 at 12:26

GoogleCodeExporter commented 9 years ago 
For reference, I requested this via email as something that I think is 
important for parity between ViewVC and gitiles if Chromium is moving from the 
former to the latter.

Original comment by pkasting@chromium.org on 5 May 2014 at 4:26

GoogleCodeExporter commented 9 years ago 
Can/should it be optional? I personally prefer the single format.

Original comment by b.kelemen@samsung.com on 6 May 2014 at 10:58

GoogleCodeExporter commented 9 years ago

Original comment by mmoss@chromium.org on 26 Aug 2014 at 12:06

GoogleCodeExporter commented 9 years ago 
Any update on the prospects for this?

Original comment by mmoss@chromium.org on 26 Aug 2014 at 12:08

GoogleCodeExporter commented 9 years ago 
Issue chromium:384604 has been merged into this issue.

Original comment by benhe...@google.com on 26 Aug 2014 at 12:16

GoogleCodeExporter commented 9 years ago 
Nope. :(

IIRC we tried using CodeMirror3 and it was too slow/awkward to use for Chromium 
project. So a new side by side view needs to be built from scratch in Gitiles, 
but that work hasn't been estimated or scheduled.

Original comment by sop@google.com on 26 Aug 2014 at 12:21