search

mfdeph / gitiles

Automatically exported from code.google.com/p/gitiles
0 stars 0 forks source link

Sort repository index in lexicographical order #37

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago 
What steps will reproduce the problem?
1. View github.googlesource.com

What is the expected output? What do you see instead?
I expect the repositories listed to be sorted lexicographically (AaBb-Az). 
Instead, they are sorted A-Za-z.

Please provide any additional information below.

I'm not sure if the correct solution is:
DefaultAccess.java:102
    Map<String, RepositoryDescription> repos = Maps.newTreeMap(String.CASE_INSENSITIVE_ORDER);

or something more complicated using Collators to sort the package in a truly 
localized way (to ensure that Foo and foo always sort the same way, rather than 
just normalizing both to foo and having the comparator return 0).

Original issue reported on code.google.com by aga...@chromium.org on 27 Nov 2013 at 8:14

GoogleCodeExporter commented 9 years ago 
https://gerrit-review.googlesource.com/52290

Now that I've written it I have mixed feelings about the whole affair as you 
can see on the change discussion.

Original comment by dborowitz@google.com on 27 Nov 2013 at 9:32

GoogleCodeExporter commented 9 years ago 
I went ahead and wrote this myself after some further investigation.
https://gerrit-review.googlesource.com/#/c/52291/

Original comment by aga...@chromium.org on 27 Nov 2013 at 9:37

GoogleCodeExporter commented 9 years ago 
Aaaaand I'm four minutes late :)

Original comment by aga...@chromium.org on 27 Nov 2013 at 9:37