mfdz / OpenTripPlanner

MFDZ (HSLdevcom/)OpenTripPlanner clone supporting Carpooling.
http://www.opentripplanner.org
Other
5 stars 4 forks source link

Performance (?) degradation when combining RAIL with BICYCLE_RENT #78

Closed leonardehrenfried closed 3 years ago

leonardehrenfried commented 3 years ago

When combining bike rental with rail OTP doesn't find the desired combination.

query{
  plan(
    from: { lat:  48.5947, lon: 8.8656 }
    to: { lat: 48.74750, lon: 9.17522 }
    transportModes: [
      { mode: RAIL },
      { mode: BICYCLE, qualifier: RENT },
    ],
    maxWalkDistance: 15000
  ) {
    itineraries {
      legs {
        mode
        rentedBike
        distance
        startTime
        endTime
        route {
          url
          mode
          shortName

        }
        trip {
          gtfsId
          tripShortName
        }
        from {
          name
          bikeRentalStation {
            name
            id
          }
        }
        to {
          name
          bikeRentalStation {
            name
            id
          }
        }
      }
    }
  }
}

The above query returns just taking the bike rental from Herrenberg to the destination.

Interestingly, if we move the destination a little bit further south we get the result we want.

Screenshot from 2021-06-01 12-02-56

query{
  plan(
    from: { lat:  48.5947, lon: 8.8656 }
    to: { lat: 48.7380, lon: 9.1638 }
    transportModes: [
      { mode: RAIL },
      { mode: BICYCLE, qualifier: RENT },
    ],
    maxWalkDistance: 15000
  ) {
    itineraries {
      legs {
        mode
        rentedBike
        distance
        startTime
        endTime
        route {
          url
          mode
          shortName

        }
        trip {
          gtfsId
          tripShortName
        }
        from {
          name
          bikeRentalStation {
            name
            id
          }
        }
        to {
          name
          bikeRentalStation {
            name
            id
          }
        }
      }
    }
  }
}
leonardehrenfried commented 3 years ago

Estimation: 2/4/3 days

leonardehrenfried commented 3 years ago

Might be fixed by opentripplanner#3502

leonardehrenfried commented 3 years ago

Looks like it's going to be fixed:

Screenshot from 2021-06-08 10-09-34

leonardehrenfried commented 3 years ago

https://dev.stadtnavi.eu/reiseplan/Herrenberg%3A%3A48.595557%2C8.8674715/Erwin-B%C3%A4lz-Stra%C3%9Fe%2C%2070597%20Stuttgart%3A%3A48.748679%2C9.1749312?time=1623148964

The upstream PR fixed it.

Thanks, @gmellemstrand.