Simplify no-thru traffic handling

mfdz / OpenTripPlanner

MFDZ (HSLdevcom/)OpenTripPlanner clone supporting Carpooling.

http://www.opentripplanner.org

Other

5 stars 4 forks source link

Simplify no-thru traffic handling #88

Closed flaktack closed 3 years ago

flaktack commented 3 years ago

These changes seem reasonable, don't break any existing tests, but no new ones are added. Not copying stateDate when setting the no-thru state might be the cause of subtle bugs, where depending on the edge traversal order routing could fail.

The code

merges the no-thru state for bicycles / motor vehicles (in State)
copies stateData when modifying the no-thru state
handles no-thru state dominance using DominanceFunction

leonardehrenfried commented 3 years ago

Does this fix the case of car routing to Marktplatz? https://www.openstreetmap.org/directions?engine=graphhopper_car&route=48.59393%2C8.87091%3B48.59631%2C8.87007

flaktack commented 3 years ago

It seems to, but the parts that depend on #66 still fail.

leonardehrenfried commented 3 years ago

Ok, nice refactoring and well spotted. Let me know if this is ready for testing. Or do you plan to add more to this PR?

flaktack commented 3 years ago

It is only draft since it needs a bit more testing -- it doesn't have any new tests, just a hunch that things should be better.

leonardehrenfried commented 3 years ago

This improves the sitution around the market square but I've still found a couple other nasty edge cases which I will document in the main ticket.