Correct the display of flex legs

mfdz / OpenTripPlanner

MFDZ (HSLdevcom/)OpenTripPlanner clone supporting Carpooling.

http://www.opentripplanner.org

Other

5 stars 4 forks source link

Correct the display of flex legs #93

Closed flaktack closed 3 years ago

flaktack commented 3 years ago

When creating itineraries for flex trips:

use the actual board / alight coordinates in leg.from / leg.to
correctly create new legs for mode transitions

This should fix the leg splitting mentioned in https://github.com/stadtnavi/digitransit-ui/issues/571

flaktack commented 3 years ago

I've manually tested, and it seems to work as expected. I've added a fix for another bug, wherein the leg.from and leg.to coordinates were not where the actual boarding / alighting were.

leonardehrenfried commented 3 years ago

Does this address this issue? https://github.com/stadtnavi/digitransit-ui/issues/571

Or this one: https://github.com/mfdz/OpenTripPlanner/issues/92

flaktack commented 3 years ago

It addresses the first one (https://github.com/stadtnavi/digitransit-ui/issues/571), #92 requires updating locations.json with a name property for each Feature. If that is done, then the API will reflect that.

leonardehrenfried commented 3 years ago

Clarification for @hbruch: this doesn't affect the routing but only it simply places the start/end location dot to where the passenger is actually picked up/dropped off.