search

mfdz / OpenTripPlanner

MFDZ (HSLdevcom/)OpenTripPlanner clone supporting Carpooling.
http://www.opentripplanner.org
Other
5 stars 4 forks source link

GTFS-rt - skip updates which may cause problems #94

Closed flaktack closed 3 years ago

flaktack commented 3 years ago

Two main cases of problematic GTFS-rt updates are handled:

  1. if the TripUpdate modified the list of stops, which mainly means SKIPPED stop updates -- in these cases the replacement Trip may have invalid StopTimes => Modifying trips is disabled.

  2. if realtime data was UNAVAILABLE for a stop, a -1 constant was used which caused problems in other parts. This is mitigated by:

    1. returning the scheduled arrival / departure time in theses cases
    2. adding an explicit check that the new / updated trip times are increasing

    If either of these checks fail, then the trip update is ignored.

leonardehrenfried commented 3 years ago

Thanks I will merge and try this out on Monday.