mfdz / gtfs-hub

Collecting, shape-enhancing, validating, fixing and (partially) merging GTFS feeds
GNU Affero General Public License v3.0
29 stars 4 forks source link

Processing fails due to "empty" stop_name #19

Closed hbruch closed 3 years ago

hbruch commented 3 years ago

Processing currently fails with:

if [ "bw-buffered.osm" != "Nein" ]; then docker run -i --rm -v /home/mfdz/gtfs-hub/data/osm:/data/osm -v /home/mfdz/gtfs-hub/data/gtfs:/data/gtfs mfdz/pfaedle --inplace -D -x /data/osm/bw-buffered.osm /data/gtfs/NWL.with_shapes.gtfs; fi
[2021-05-12 06:47:31.287] INFO : Reading /data/gtfs/NWL.with_shapes.gtfs ...
[2021-05-12 06:47:31.344] ERROR: Could not parse input GTFS feed, reason was:
/data/gtfs/NWL.with_shapes.gtfs/stops.txt:490: in field 'stop_name', expected non-empty string
make: *** [makefile:151: data/gtfs/NWL.with_shapes.gtfs] Error 4

This seems to caused by some faulty doubleqoute handling, probably of pfaedle, as NWL.filtered.gtfs still looks ok:

NWL.raw.gtfs # head -n 490 stops.txt | tail -n 1
"de:03404:71809::2","","Osnabrück, "emma"","52.2754477","8.0371819","","","","0",""

NWL.filtered.gtfs #head -n 490 stops.txt | tail -n 1
"de:03404:71809::2","","Osnabrück, "emma"","52.2754477","8.0371819","","","","0",""
hbruch commented 3 years ago

Fixed via aac45d149f43fae01ce30bd175e7556620179718. Additionallly excluded NWL from shape enhancement, as we currently only perform this for the BW region.