search

mfelicio / NDomain

.NET framework that simplifies software development using DDD, Event Sourcing and CQRS based architectures.
MIT License
54 stars 19 forks source link

Add Serilog logging support #2

Closed jamesholcomb closed 9 years ago

jamesholcomb commented 9 years ago

I was perusing the PR and noticed the original solution is in VS2012 (I use VS2015).

According to MS, it should interoperate

https://msdn.microsoft.com/en-US/library/hh266747%28v=vs.140%29.aspx

but I don't have a version to test this theory.

mfelicio commented 9 years ago

Great addition! Let me test on my VS 2012.

jamesholcomb commented 9 years ago

https://github.com/serilog/serilog/issues/91#issuecomment-37372508

I had followed the conventions you used for NLog when using global::

mfelicio commented 9 years ago

You're right. I had to use global because the of the namespace collisions but I really don't like to use it. I will change later the name of the classes to NLogLogger and SerilogLogger to avoid namespace conflicts.

Thank's for fixing the other things :+1: . I'm merging the PR now!