search

mfenner / jekyll-pandoc

Jekyll Pandoc markdown converter as Ruby gem
MIT License
82 stars 10 forks source link

Jekyll v3 #6

Closed edsu closed 8 years ago

edsu commented 9 years ago

fixes #5

Support for Jekyll 3 custom markdown processors means we can remove the monkey patching, and also the need for testing it.

If you like this I would recommend you hold off on releasing this until Jekyll 3 is out of beta.

edsu commented 9 years ago

@mfenner I see you've decided to move forward on master without merging this PR to simplify things. So there are tons of conflicts now. I'm not sure this PR will still be useful to you.

I do think you can simplify things substantially in this gem by removing the monkey patching since Jekyll3 has functionality to allow custom markdown processors now. If you would like me to resend this PR based off your latest modifications let me know.

mfenner commented 9 years ago

I think for the time being we want to support Jekyll v2 as well. In Jekyll v1 monkey patching was needed, in v2 the main reason is so that we can say markdown: pandoc instead of markdown: PandocProcessorin _config.yml.

There are several ways we can go about this and I have no strong opinions what we do under the hood as long as _config.yml says markdown: pandoc.

mfenner commented 9 years ago

I am happy to clean up the conflicts once we have sorted this out. And maybe you can convince me to use markdown: PandocProcessor.

edsu commented 9 years ago

There were too many conflicts to resolve unfortuately. If you really want to keep markdown: pandoc I believe you can name your custom processor Jekyll::Converters::Markdown::pandoc. Perhaps Jekyll::Converters::Markdown::Pandoc would be a good compromise, so you would have markdown: Pandoc? At any rate, avoiding monkey-patching seems well worth it to me.

steinwaywhw commented 8 years ago

Any updates?

elotroalex commented 8 years ago

Any updates on the conflict resolution? So far no major snags using jekyll 3 and the base repo, but just in case. Hey, @edsu, nice to run into you here.

edsu commented 8 years ago

I'm not sure what the status of jekyll3 support is.

jekyll3 simplifies things quite a bit. I've been using my jekyll3 branch for a few months. As you can see the plugin has been reduced to one 32 line ruby file.

/me waves to @elotroalex

mfenner commented 8 years ago

@edsu I am sorry that it took me so long, but I have finally released version 2.0.1 with proper support for jekyll 3. Part of the delay was because the old version worked just fine with jekyll 3, but the monkey patching was of course no longer needed.

Make sure that you change markdown: pandoc to markdown: Pandoc in _config.yml.