search

mfenniak / rethinkdb-net

A C# / .NET client driver for RethinkDB.
Other
247 stars 37 forks source link

Fixed handling of DateTime.MinValue. Issue #240 #241

Closed ThomasHoest closed 8 years ago

ThomasHoest commented 8 years ago

Fixed long and ulong MaxValue and MinValue checks

mfenniak commented 8 years ago

Sure, that change to the test makes sense; we just can't represent the long values with the same precision as the double. But, it looks like the same test failure you encountered in the long datum converter still exists in the unsigned long datum converter. Could you please fix that up too?

Errors and Failures: 1) Test Failure : RethinkDb.Test.DatumConverters.UnsignedLongDatumConverterTests.ConvertDatum_ValueTooLargeToRepresentAsLongProperly_ThrowException System.NotSupportedException was expected

Other than that, this looks good to merge. If you can push a fix for that and the CI goes green, I'll merge it up.

ThomasHoest commented 8 years ago

Ups forgot that one. It should be fixed now