search

mfenniak / rethinkdb-net

A C# / .NET client driver for RethinkDB.
Other
247 stars 37 forks source link

References to nunit.core & nunit.framework seem incorrect in Visual Studio #76

Closed mfenniak closed 11 years ago

mfenniak commented 11 years ago

The current references work in MonoDevelop. Need to test with VS2012 and figure out what will work in both environments.

squidge commented 11 years ago

This is also an issue in Xamarin Studio. XS comes with version 2.6.0.12051 and MD with 2.6.0.0

dragan commented 11 years ago

I'm a fan of NUnit, but XUnit may be better for the job. We can then use the nuget packages and setup an automated build to run the tests. I'd be happy to help and take this.

squidge commented 11 years ago

The problem with xUnit is (as far as I am aware) there is no test runner for MonoDevelop (Xamarin Studio) so we would have to resource to something like rake which I have used in other projects but we lose the ability to debug which sometimes is necessary. We can still use the nuget packages and have automated builds if we decide to stick with nUnit.

dragan commented 11 years ago

I realize that there's no test runner support in MD or XS for xUnit. If you think that having test runner support out weighs the fact that xUnit has better support for async and makes the tests cleaner.

Either way, there should be an automated build, see #78, and I'd be happy to take that on and at the same time fix this issue if you want to stay with nunit. Once there's an automated build, we can set this up on a CI server, see #77. I can help out with that as well.

squidge commented 11 years ago

I am easy either way. The current integration tests require an instance of rethinkdb running, so we need to think how to solve that when building on teamcity.

Let's see what @mfenniak has to say.

mfenniak commented 11 years ago

@squidge, can you test pull request #79 and see if it works in your environment?

Regarding switching to another test framework (xUnit), losing the integrated test runner seems like a poor trade-off to me.