mfenniak / rethinkdb-net

A C# / .NET client driver for RethinkDB.
Other
247 stars 37 forks source link

DateTime and DateTime? support #93

Closed karlgrz closed 11 years ago

karlgrz commented 11 years ago

Addresses DateTime and DateTime? serialization per Issue #86

mfenniak commented 11 years ago

Hey @karlgrz, do you have any attachment to the string format you used for DateTime? I might like to change it to use RFC3339 format so that it's more readable to other, non-.NET clients, if you have no objection.

karlgrz commented 11 years ago

I have no objections to that at all. I'll go ahead and update that.

On Wed, Apr 24, 2013 at 8:40 PM, Mathieu Fenniak notifications@github.comwrote:

Hey @karlgrz https://github.com/karlgrz, do you have any attachment to the string format you used for DateTime? I might like to change it to use RFC3339 http://tools.ietf.org/html/rfc3339 format so that it's more readable to other, non-.NET clients, if you have no objection.

— Reply to this email directly or view it on GitHubhttps://github.com/mfenniak/rethinkdb-net/pull/93#issuecomment-16984400 .

karlgrz commented 11 years ago

Done.

On Thu, Apr 25, 2013 at 8:04 AM, Karl Grzeszczak karlgrz@gmail.com wrote:

I have no objections to that at all. I'll go ahead and update that.

On Wed, Apr 24, 2013 at 8:40 PM, Mathieu Fenniak <notifications@github.com

wrote:

Hey @karlgrz https://github.com/karlgrz, do you have any attachment to the string format you used for DateTime? I might like to change it to use RFC3339 http://tools.ietf.org/html/rfc3339 format so that it's more readable to other, non-.NET clients, if you have no objection.

— Reply to this email directly or view it on GitHubhttps://github.com/mfenniak/rethinkdb-net/pull/93#issuecomment-16984400 .