mfesiem / msiempy

McAfee SIEM API Python wrapper
https://mfesiem.github.io/docs/msiempy/msiempy.html
MIT License
23 stars 9 forks source link

ESM Login Password not base64 encoded #100

Closed Balzu closed 3 years ago

Balzu commented 3 years ago

Describe The password is not base64 encoded in msiempy\core\session.py

Details: Password is not base64 encoded in msiempy\core\session.py. Because of this, I was not able to login to ESM. I don't know if it is supposed to be base64 encoded always, or if there are version that accept it not base-64 encoded.

    def login(self, retry=1):
    """
    Authentication is done lazily upon the first call to `msiempy.core.session.NitroSession.request` method, but you can still do 
    it manually by calling this method.

    Raises:
        `msiempy.core.session.NitroError` if login fails
    """
    userb64 = tob64(self.config.user)
    passb64 = self.config.passwd
Balzu commented 3 years ago

I was reviewing the doumentation, actually it is envisioned to write the password base64 encoded in the config file, so no issue is present

tristanlatr commented 3 years ago

Great to hear! Happy coding!