mfesiem / msiempy

McAfee SIEM API Python wrapper
https://mfesiem.github.io/docs/msiempy/msiempy.html
MIT License
23 stars 9 forks source link

Watchlist attributes stored as object properties #35

Closed tristanlatr closed 4 years ago

tristanlatr commented 4 years ago

Hi Andy,

Just wondering why you declared all those Watchlist attributes as properties and not simply as key/value of the underlying dict object ? Is there a special reason for this ?

You can alway access underlying dict obejct of any NitroDict class by calling the data property. example : self.data['name']='the watchlist name'

Thanks

https://github.com/mfesiem/msiempy/blob/372ed4efcdcee874b185a181254529c9a3146fc0/msiempy/watchlist.py#L123

andywalden commented 4 years ago

It's a good question. I'm not sure what my frame of mind was there, I'll back it out while I'm working on why-ever the watchlist test is now generating a 400 error.

tristanlatr commented 4 years ago

I think it has always done that, retreiving Watchlist values never worked..

andywalden commented 4 years ago

Fixed in b77ae24fb53fc6b2a2b6213a117cf9d722f10a1d