search

mff-uk / dataspecer

https://dataspecer.com
MIT License
23 stars 7 forks source link

Data structure name in specification manager shall be the name of the PSM schema in the schema generator #117

Open martinnec opened 2 years ago

martinnec commented 2 years ago

Here:

image

I would like to see:

image
sstenchlak commented 2 years ago

This works. The problem is that the specification manager prefers English over the Czech language, and in the schema generator, both Czech and English language mutations are created. You have probably edited only the Czech one; therefore, the change you have made is not visible in the specification manager.

Do you @martinnec want me to make some modifications to make it straightforward?

martinnec commented 2 years ago

Ok, then I would expect that for English mutation I do not see any label when there is no English label specified. In my "problem" screenshot, I see Czech labels in English mutation. It would be better to see no labels which forces me to complement them.

But let it be for now. I switch this to Discussion and assign @jakubklimek to give his opinion.

jakubklimek commented 2 years ago

OK, I did not know that we are generating both Czech and English versions of specifications (and schemas?) Makes sense though, especially when we want the solution to be independent of SSP and usable in other situations as well.

Nevertheless, the question here is about the behavior when there is no label, i.e.

Ok, then I would expect that for English mutation I do not see any label when there is no English label specified.

So, what is the behavior? Is there a fallback to the Czech label for English specifications (and vice versa) when English label is not specified? Will it be blank?

sstenchlak commented 2 years ago

Yes, there should be a fallback to the second preferred language (English or Czech) or to another language mutation that exists.

The intention is rather to show something than nothing.

I can visually distinguish labels that do not come from the current language mutation. For example: grey color and a badge with the label's language.

jakubklimek commented 2 years ago

I can visually distinguish labels that do not come from the current language mutation. For example: grey color and a badge with the label's language.

@sstenchlak I would quite like this solution for the documentation. It makes it clear where the text comes from and the author can act on it. @martinnec what do you think?